From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932901Ab2ISR6U (ORCPT ); Wed, 19 Sep 2012 13:58:20 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47026 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932821Ab2ISR6R (ORCPT ); Wed, 19 Sep 2012 13:58:17 -0400 Date: Wed, 19 Sep 2012 19:58:15 +0200 Message-ID: From: Takashi Iwai To: Ondrej Zary Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [RFC PATCH v2 0/5] snd-ice1712: Add Philips PSC724 Ultimate Edge In-Reply-To: <201209191903.14690.linux@rainbow-software.org> References: <1347994716-10251-1-git-send-email-linux@rainbow-software.org> <201209191903.14690.linux@rainbow-software.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 19 Sep 2012 19:03:14 +0200, Ondrej Zary wrote: > > On Wednesday 19 September 2012 17:28:21 Takashi Iwai wrote: > > At Tue, 18 Sep 2012 20:58:31 +0200, > > > > Ondrej Zary wrote: > > > Hello, > > > this is second attempt to add Philips PSC724 Ultimate Edge sound card > > > support to snd-ice1712 driver. Unlike other snd-ice1712 subdrivers, the > > > codec code is splitted into separate modules and thus reusable by other > > > ice1712 subdrivers. > > > > Well, the problem is that most of ice17xx boards use only a part of > > channels on codecs. Thus you don't want to expose controls for all > > channels, too. Otherwise user will get confusing dead controls. > > The controls can be easily hidden by setting its name to NULL. It's even used > in the psc724 subdriver. > > > If these new modules are supposed to be used by other ice1712/ice1724 > > sub drivers, they should provide some good binding mechanism, too. > > (And that's one of the good reasons why ASoC has been nominated.) > > They're easy to use, you just need to provide wm87x6_write() function. I think > that other subdrivers could be easily converted to use this (with hardware to > test). OK, but I'd like to have modules only when the code sharing happens. Also, it'd be better to have different module names, indicating that they are ice17xx-specific. thanks, Takashi > > > thanks, > > > > Takashi > > > > > Working: all analog outputs (front, rear, center+lfe, headphone) and > > > inputs (front mic, rear mic, line, cd, aux), mixer, headphone jack > > > detection, suspend/resume > > > > > > Currently untested: SPDIF > > > > > > Buggy: switching AGC mode in mixer causes alsamixer to crash - looks like > > > it does not like notifications about control activating/deactivating > > > _______________________________________________ > > > Alsa-devel mailing list > > > Alsa-devel@alsa-project.org > > > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >