From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041Ab1LPGxl (ORCPT ); Fri, 16 Dec 2011 01:53:41 -0500 Received: from cantor2.suse.de ([195.135.220.15]:55732 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751293Ab1LPGxj (ORCPT ); Fri, 16 Dec 2011 01:53:39 -0500 Date: Fri, 16 Dec 2011 07:53:37 +0100 Message-ID: From: Takashi Iwai To: Joerg Roedel Cc: Rakib Mullick , Liam Girdwood , Mark Brown , Jaroslav Kysela , , , akpm@linux-foundation.org Subject: Re: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c In-Reply-To: <20111215172453.GH2112@amd.com> References: <20111215165248.GG2112@amd.com> <20111215172453.GH2112@amd.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 15 Dec 2011 18:24:54 +0100, Joerg Roedel wrote: > > On Thu, Dec 15, 2011 at 11:16:52PM +0600, Rakib Mullick wrote: > > On Thu, Dec 15, 2011 at 10:52 PM, Joerg Roedel wrote: > > > (again with mailing lists on Cc, sorry) > > > > > > Hi, > > > > > > I tested current linux-next against my iommu-configs and found a compile > > > error in sound/soc/mid-x86/sst_platform.c. The variable ret_val in the > > > sst_platform_open() function is used but not declared. Attached patch > > > fixes this. > > > > > > > While fixing any kind of error/warning, it's nice to have > > error/warning message in changelog. > > Okay, here it is: > > >From 9d0876632c4fc07254eafbe5018e68963bdcfe17 Mon Sep 17 00:00:00 2001 > From: Joerg Roedel > Date: Thu, 15 Dec 2011 17:39:31 +0100 > Subject: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The variable ret_val is used but not declared. This causes > the following compile error: > > sound/soc/mid-x86/sst_platform.c: In function ‘sst_platform_open’: > sound/soc/mid-x86/sst_platform.c:274:2: error: ‘ret_val’ undeclared (first use in this function) > sound/soc/mid-x86/sst_platform.c:274:2: note: each undeclared identifier is reported only once for each function it appears in > make[1]: *** [sound/soc/mid-x86/sst_platform.o] Error 1 > > Fix this. > > Signed-off-by: Joerg Roedel Thanks, I applied the patch now to sound git tree. Mark, could you merge back topic/asoc branch into your tree later? Takashi > --- > sound/soc/mid-x86/sst_platform.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/sound/soc/mid-x86/sst_platform.c b/sound/soc/mid-x86/sst_platform.c > index 24f9471..11c39c5 100644 > --- a/sound/soc/mid-x86/sst_platform.c > +++ b/sound/soc/mid-x86/sst_platform.c > @@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream) > { > struct snd_pcm_runtime *runtime = substream->runtime; > struct sst_runtime_stream *stream; > + int ret_val; > > pr_debug("sst_platform_open called\n"); > > -- > 1.7.5.4 > > > -- > AMD Operating System Research Center > > Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach > General Managers: Alberto Bozzo, Andrew Bowd > Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 >