From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753859Ab1LAHkl (ORCPT <rfc822;w@1wt.eu>);
	Thu, 1 Dec 2011 02:40:41 -0500
Received: from cantor2.suse.de ([195.135.220.15]:40942 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752582Ab1LAHkk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 1 Dec 2011 02:40:40 -0500
Date: Thu, 01 Dec 2011 08:40:38 +0100
Message-ID: <s5hhb1kvix5.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
        Liam Girdwood <lrg@ti.com>, Jaroslav Kysela <perex@perex.cz>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
        Mike Frysinger <vapier@gentoo.org>, Daniel Mack <zonque@gmail.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com,
        kok.howg.ewe@intel.com
Subject: Re: [PATCH v3] sound/soc/codecs: add LAPIS Semiconductor ML26124
In-Reply-To: <CANKRQnjpYDJWfJO-G5HsE6es7metHeqgP32R3eo99MaE2zdNpQ@mail.gmail.com>
References: <1322474755-18785-1-git-send-email-tomoya.rohm@gmail.com>
	<20111128132317.GD8275@opensource.wolfsonmicro.com>
	<CANKRQng3YtYZggVWp3BWyaWyaHAbN1hccJksWELnv2co37rEcQ@mail.gmail.com>
	<20111129122916.GM2851@opensource.wolfsonmicro.com>
	<CANKRQnjpYDJWfJO-G5HsE6es7metHeqgP32R3eo99MaE2zdNpQ@mail.gmail.com>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Thu, 1 Dec 2011 16:34:14 +0900,
Tomoya MORINAGA wrote:
> 
> 2011/11/29 Mark Brown <broonie@opensource.wolfsonmicro.com>:> > These
> should mathc.
> > Match.
> 
> Sorry, still I couldn't understand.
> What does your "match" mean for anything?

You need to have read Mark's comment carefully.  He quoted another
line before that.

================================================================
> +	SOC_SINGLE_TLV("EQ Band1 Input Volume", ML26124_EQ_GAIN_BRAND1, 0,
> +			0xff, 1, eq_band_gain),

> +	SOC_SINGLE("EQ BAND1 Switch", ML26124_FILTER_EN, 3, 1, 0),

These should mathc.
================================================================

So, you have two inconsistent names for EQ band1.


Takashi