From: Takashi Iwai <tiwai@suse.de>
To: Julia Lawall <julia@diku.dk>
Cc: Jaroslav Kysela <perex@perex.cz>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 7/7] sound: Use kzalloc for allocating only one thing
Date: Sat, 19 Dec 2009 09:40:55 +0100 [thread overview]
Message-ID: <s5hhbrn4aqw.wl%tiwai@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0912190817460.30546@ask.diku.dk>
At Sat, 19 Dec 2009 08:18:03 +0100 (CET),
Julia Lawall wrote:
>
> From: Julia Lawall <julia@diku.dk>
>
> Use kzalloc rather than kcalloc(1,...)
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> @@
>
> - kcalloc(1,
> + kzalloc(
> ...)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied now. Thanks.
Takashi
>
> ---
> sound/isa/msnd/msnd_midi.c | 2 +-
> sound/pci/hda/patch_realtek.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff -u -p a/sound/isa/msnd/msnd_midi.c b/sound/isa/msnd/msnd_midi.c
> --- a/sound/isa/msnd/msnd_midi.c 2009-03-28 23:34:55.000000000 +0100
> +++ b/sound/isa/msnd/msnd_midi.c 2009-12-19 07:52:27.000000000 +0100
> @@ -162,7 +162,7 @@ int snd_msndmidi_new(struct snd_card *ca
> err = snd_rawmidi_new(card, "MSND-MIDI", device, 1, 1, &rmidi);
> if (err < 0)
> return err;
> - mpu = kcalloc(1, sizeof(*mpu), GFP_KERNEL);
> + mpu = kzalloc(sizeof(*mpu), GFP_KERNEL);
> if (mpu == NULL) {
> snd_device_free(card, rmidi);
> return -ENOMEM;
> diff -u -p a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> --- a/sound/pci/hda/patch_realtek.c 2009-12-17 08:30:15.000000000 +0100
> +++ b/sound/pci/hda/patch_realtek.c 2009-12-19 07:52:50.000000000 +0100
> @@ -12857,7 +12857,7 @@ static int patch_alc268(struct hda_codec
> int board_config;
> int i, has_beep, err;
>
> - spec = kcalloc(1, sizeof(*spec), GFP_KERNEL);
> + spec = kzalloc(sizeof(*spec), GFP_KERNEL);
> if (spec == NULL)
> return -ENOMEM;
>
>
prev parent reply other threads:[~2009-12-19 8:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-19 7:18 Julia Lawall
2009-12-19 8:40 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hhbrn4aqw.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®