From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1757340AbZADLYd@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757340AbZADLYd (ORCPT <rfc822;w@1wt.eu>);
	Sun, 4 Jan 2009 06:24:33 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751531AbZADLYX
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sun, 4 Jan 2009 06:24:23 -0500
Received: from mx1.suse.de ([195.135.220.2]:49084 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751357AbZADLYX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 4 Jan 2009 06:24:23 -0500
Date: Sun, 04 Jan 2009 12:24:20 +0100
Message-ID: <s5hhc4f2u1n.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Julia Lawall <julia@diku.dk>
Cc: alsa-devel@alsa-project.org, gregkh@suse.de, linux-kernel@vger.kernel.org,
       kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] sound/usb: Use negated usb_endpoint_xfer_control, etc
In-Reply-To: <Pine.LNX.4.64.0901031753120.9811@pc-004.diku.dk>
References: <Pine.LNX.4.64.0901031753120.9811@pc-004.diku.dk>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Sat, 3 Jan 2009 17:54:53 +0100 (CET),
Julia Lawall wrote:
> 
> From: Julia Lawall <julia@diku.dk>
> 
> This patch extends 42a6e66f1e40a930d093c33ba0bb9d8d8e4555ed by using
> usb_endpoint_xfer_control, usb_endpoint_xfer_isoc, usb_endpoint_xfer_bulk,
> and usb_endpoint_xfer_int in the negated case as well.
> 
> This patch also rewrites some calls to usb_endpoint_dir_in as negated calls
> to !usb_endpoint_dir_out, and vice versa, to better correspond to the
> intent of the original code.
> 
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
> 
> // <smpl>
> @@ struct usb_endpoint_descriptor *epd; @@
> 
> - (usb_endpoint_type(epd) != \(USB_ENDPOINT_XFER_CONTROL\|0\))
> + !usb_endpoint_xfer_control(epd)
> 
> @@ struct usb_endpoint_descriptor *epd; @@
> 
> - (usb_endpoint_type(epd) != \(USB_ENDPOINT_XFER_ISOC\|1\))
> + !usb_endpoint_xfer_isoc(epd)
> 
> @@ struct usb_endpoint_descriptor *epd; @@
> 
> - (usb_endpoint_type(epd) != \(USB_ENDPOINT_XFER_BULK\|2\))
> + !usb_endpoint_xfer_bulk(epd)
> 
> @@ struct usb_endpoint_descriptor *epd; @@
> 
> - (usb_endpoint_type(epd) != \(USB_ENDPOINT_XFER_INT\|3\))
> + !usb_endpoint_xfer_int(epd)
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@diku.dk>

Applied now.  Thanks.


Takashi