From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1756126AbYK0PEs@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756126AbYK0PEs (ORCPT <rfc822;w@1wt.eu>);
	Thu, 27 Nov 2008 10:04:48 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752943AbYK0PEh
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 27 Nov 2008 10:04:37 -0500
Received: from ns.suse.de ([195.135.220.2]:41793 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752736AbYK0PEg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 27 Nov 2008 10:04:36 -0500
Date: Thu, 27 Nov 2008 16:04:34 +0100
Message-ID: <s5hhc5t5hx9.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Julia Lawall <julia@diku.dk>
Cc: perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
       kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] sound/pci/mixart/mixart.c: Add missing snd_card_free
In-Reply-To: <Pine.LNX.4.64.0811271539400.15160@pc-004.diku.dk>
References: <Pine.LNX.4.64.0811271423040.15160@pc-004.diku.dk>
	<Pine.LNX.4.64.0811271432350.15160@pc-004.diku.dk>
	<s5hk5apz3md.wl%tiwai@suse.de>
	<Pine.LNX.4.64.0811271445310.15160@pc-004.diku.dk>
	<s5hljv55j7o.wl%tiwai@suse.de>
	<Pine.LNX.4.64.0811271539400.15160@pc-004.diku.dk>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Thu, 27 Nov 2008 15:40:40 +0100 (CET),
Julia Lawall wrote:
> 
> From: Julia Lawall <julia@diku.dk>
> 
> The function snd_mixart_create creates a link between mgr and card that
> allows snd_mixart_free to free card as well.  But if snd_mixart_create
> fails, then the link has not been created and card has to be freed explicitly.
> 
> 
> The semantic match that finds the problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
(snip)
> Signed-off-by: Julia Lawall <julia@diku.dk>

Thanks, applied now.


Takashi