mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 13/12] sound: au88x0_core.c fix incorrect signedness	warnings
Date: Thu, 28 Feb 2008 12:11:06 +0100	[thread overview]
Message-ID: <s5hhcfts5dh.wl%tiwai@suse.de> (raw)
In-Reply-To: <1204160803.20280.62.camel@brick>

> Subject: Re: [PATCH 13/12] sound: au88x0_core.c fix incorrect signedness warnings 

The patch overflow?  ;-)

At Wed, 27 Feb 2008 17:06:43 -0800,
Harvey Harrison wrote:
> 
> Fixes the following, repeated at every callsite, vortex->fixed_res is always
> passed in this argument, the change to unsigned int won't change anything.
> 
> sound/pci/au88x0/au88x0_core.c:2047:54: warning: incorrect type in argument 2 (different signedness)
> sound/pci/au88x0/au88x0_core.c:2047:54:    expected int *resmap
> sound/pci/au88x0/au88x0_core.c:2047:54:    got unsigned int *<noident>

I thought this warning is rather a compiler issue.  We had this with
some gcc version but it was suppressed as default in the end.

Fine to fix in the code as it's obviously correct, though.


thanks,

Takashi

      reply	other threads:[~2008-02-28 11:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-28  1:06 Harvey Harrison
2008-02-28 11:11 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hhcfts5dh.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=harvey.harrison@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®