From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966187AbWKTQv1 (ORCPT ); Mon, 20 Nov 2006 11:51:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S966190AbWKTQv1 (ORCPT ); Mon, 20 Nov 2006 11:51:27 -0500 Received: from mx2.suse.de ([195.135.220.15]:24236 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S966189AbWKTQv0 (ORCPT ); Mon, 20 Nov 2006 11:51:26 -0500 Date: Mon, 20 Nov 2006 17:51:24 +0100 Message-ID: From: Takashi Iwai To: Adrian Bunk Cc: perex@suse.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [Alsa-devel] [RFC: 2.6 patch] make sound/core/control.c:snd_ctl_new() static In-Reply-To: <20061117170226.GG31879@stusta.de> References: <20061117170226.GG31879@stusta.de> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27) (fiddleheads) (+CVS-20060704) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 17 Nov 2006 18:02:26 +0100, Adrian Bunk wrote: > > Now that everyone uses snd_ctl_new1() and noone is using snd_ctl_new() > anymore, we can make it static. > > Signed-off-by: Adrian Bunk This makes sense. I merged it to ALSA tree. Thanks. Takashi > > --- > > Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl | 10 ---------- > include/sound/control.h | 1 - > sound/core/control.c | 5 ++--- > 3 files changed, 2 insertions(+), 14 deletions(-) > > --- linux-2.6.19-rc5-mm2/Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl.old 2006-11-17 16:48:12.000000000 +0100 > +++ linux-2.6.19-rc5-mm2/Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl 2006-11-17 16:48:22.000000000 +0100 > @@ -3691,16 +3691,6 @@ > > > > - Here, the chip instance is retrieved via > - snd_kcontrol_chip() macro. This macro > - just accesses to kcontrol->private_data. The > - kcontrol->private_data field is > - given as the argument of snd_ctl_new() > - (see the later subsection > - Constructor). > - > - > - > The value field is depending on > the type of control as well as on info callback. For example, > the sb driver uses this field to store the register offset, > --- linux-2.6.19-rc5-mm2/include/sound/control.h.old 2006-11-17 16:48:35.000000000 +0100 > +++ linux-2.6.19-rc5-mm2/include/sound/control.h 2006-11-17 16:48:39.000000000 +0100 > @@ -108,7 +108,6 @@ > > void snd_ctl_notify(struct snd_card * card, unsigned int mask, struct snd_ctl_elem_id * id); > > -struct snd_kcontrol *snd_ctl_new(struct snd_kcontrol * kcontrol, unsigned int access); > struct snd_kcontrol *snd_ctl_new1(const struct snd_kcontrol_new * kcontrolnew, void * private_data); > void snd_ctl_free_one(struct snd_kcontrol * kcontrol); > int snd_ctl_add(struct snd_card * card, struct snd_kcontrol * kcontrol); > --- linux-2.6.19-rc5-mm2/sound/core/control.c.old 2006-11-17 16:48:46.000000000 +0100 > +++ linux-2.6.19-rc5-mm2/sound/core/control.c 2006-11-17 16:49:39.000000000 +0100 > @@ -183,7 +183,8 @@ > * > * Returns the pointer of the new instance, or NULL on failure. > */ > -struct snd_kcontrol *snd_ctl_new(struct snd_kcontrol *control, unsigned int access) > +static struct snd_kcontrol *snd_ctl_new(struct snd_kcontrol *control, > + unsigned int access) > { > struct snd_kcontrol *kctl; > unsigned int idx; > @@ -201,8 +202,6 @@ > return kctl; > } > > -EXPORT_SYMBOL(snd_ctl_new); > - > /** > * snd_ctl_new1 - create a control instance from the template > * @ncontrol: the initialization record > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/alsa-devel >