From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1751000AbWDRKSB@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751000AbWDRKSB (ORCPT <rfc822;willy@w.ods.org>);
	Tue, 18 Apr 2006 06:18:01 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751001AbWDRKSB
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 18 Apr 2006 06:18:01 -0400
Received: from mx1.suse.de ([195.135.220.2]:2988 "EHLO mx1.suse.de")
	by vger.kernel.org with ESMTP id S1750987AbWDRKSA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 18 Apr 2006 06:18:00 -0400
Date: Tue, 18 Apr 2006 12:17:46 +0200
Message-ID: <s5hhd4r9ohh.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Lee Revell <rlrevell@joe-job.com>,
       Adrian McMenamin <adrian@mcmen.demon.co.uk>,
       Paul Mundt <lethal@linux-sh.org>,
       Alsa-devel <alsa-devel@lists.sourceforge.net>,
       linux-sh <linuxsh-dev@lists.sourceforge.net>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Alsa-devel] Re: [linuxsh-dev] [PATCH] ALSA driver for Yamaa AICA on Sega Dreamcast
In-Reply-To: <20060417220512.GA16119@infradead.org>
References: <1145232784.12804.2.camel@localhost.localdomain>
	<20060417012913.GA16821@linux-sh.org>
	<1145304037.9244.27.camel@localhost.localdomain>
	<1145310435.16138.83.camel@mindpipe>
	<20060417220512.GA16119@infradead.org>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25)
 (eggplant) (+CVS-20060326) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Mon, 17 Apr 2006 23:05:12 +0100,
Christoph Hellwig wrote:
> 
> On Mon, Apr 17, 2006 at 05:47:15PM -0400, Lee Revell wrote:
> > On Mon, 2006-04-17 at 21:00 +0100, Adrian McMenamin wrote:
> > > But I am happy to change it.
> > > 
> > > 
> > 
> > Please don't - when adding code to a subsystem with different
> > conventions than mainline the FAQ says to follow the subsystem
> > conventions.
> 
> Nope.  Alsa needs to gradually converted from something that looks like
> cat puke to normal kernel style.  Every new driver that's written properly
> helps.

Heh, the suggested line is what CondingStyle suggets -- the output of
indent program.  Yeah, but better to fix "bad programming" :)


Takashi