From: Takashi Iwai <tiwai@suse.de>
To: Roland Dreier <rolandd@cisco.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add PCI IDs so RME32 and RME96 drivers build
Date: Wed, 14 Sep 2005 11:31:33 +0200 [thread overview]
Message-ID: <s5hhdcodmh6.wl%tiwai@suse.de> (raw)
In-Reply-To: <52r7bs2tm2.fsf@cisco.com>
At Tue, 13 Sep 2005 20:52:53 -0700,
Roland Dreier wrote:
>
> While doing an allyesconfig build, I noticed that the commit
>
> commit 8cdfd2519c6c9a1e6057dc5970b2542b35895738
> Author: Takashi Iwai <tiwai@suse.de>
> Date: Wed Sep 7 14:08:11 2005 +0200
>
> [ALSA] Remove superfluous PCI ID definitions
>
> broke the RME32 and RME96 drivers, since the PCI IDs they use seem to
> have changed names. Here's a patch to fix this -- compile tested
> only, since I have no idea what the hardware even is.
>
>
> Fix the build of the RME32 and RME96 drivers by having them use the
> PCI_DEVICE_ID_RME_xxx names defined in <linux/pci_ids.h> instead of
> the PCI_DEVICE_ID_xxx names that they used to define themselves.
>
> Also fix the typo in the id PCI_DEVICE_IDRME__DIGI96_8_PAD_OR_PST
> so the name is PCI_DEVICE_ID_RME_DIGI96_8_PAD_OR_PST.
>
> Signed-off-by: Roland Dreier <rolandd@cisco.com>
Thanks. It seems that I submitted an older file.
It was intentional to use PCI_DEVICE_ID_DIGI96* to keep the patch
smaller. But, PCI_DEVICE_ID_RME_* looks more consistent.
Please apply it.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Takashi
prev parent reply other threads:[~2005-09-14 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-14 3:52 Roland Dreier
2005-09-14 9:31 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hhdcodmh6.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®