From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 517E4C433EF
	for <linux-kernel@archiver.kernel.org>; Thu, 10 Mar 2022 13:29:55 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S242411AbiCJNay (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 10 Mar 2022 08:30:54 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60462 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S239631AbiCJNax (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Mar 2022 08:30:53 -0500
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E2701070A6
        for <linux-kernel@vger.kernel.org>; Thu, 10 Mar 2022 05:29:52 -0800 (PST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out2.suse.de (Postfix) with ESMTP id 79BA61F381;
        Thu, 10 Mar 2022 13:29:51 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1646918991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=p+BwOJv9TrkOBx6KAoXGGCOccfxsJ7PRbs724DyoEp8=;
        b=uwM/3fmSXvKY+Y9VgLnmTBZrCkcyUV0lyDO7Uvn35myQ+ZnYD+0j2A4SQDOx6YYB8l1ww6
        pzIDPxcA9fK39RKuNNV+Y02rhQwLnUC59H+zsvarGs5HAYBIOe/VGBeVXpOJUxBTgoKUXf
        XOD09JVtJ98hF2G475XFORRUCVJIc4s=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1646918991;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=p+BwOJv9TrkOBx6KAoXGGCOccfxsJ7PRbs724DyoEp8=;
        b=k1pHIieTXWKiyI8BKoqkk+7qvSB+TsV7IO8Rmu2PjRSmNXRoHuEgH96OzGQzBDy609VO87
        0bWW7t5qSrJXt5Bg==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id 0477BA3B88;
        Thu, 10 Mar 2022 13:29:50 +0000 (UTC)
Date:   Thu, 10 Mar 2022 14:29:50 +0100
Message-ID: <s5hilsmey0h.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     huangwenhui <huangwenhuia@uniontech.com>
Cc:     perex@perex.cz, tiwai@suse.com, jeremy.szu@canonical.com,
        hui.wang@canonical.com, wse@tuxedocomputers.com, cam@neo-zeon.de,
        kailang@realtek.com, tanureal@opensource.cirrus.com, sami@loone.fi,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671
In-Reply-To: <20220310130301.22827-1-huangwenhuia@uniontech.com>
References: <20220310130301.22827-1-huangwenhuia@uniontech.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 10 Mar 2022 14:03:01 +0100,
huangwenhui wrote:
> 
> On a HP 288 Pro G8, the front Mic could not be detected.
> 
> Signed-off-by: huangwenhui <huangwenhuia@uniontech.com>

Thanks for the patch.  Most of the changes look OK, but one thing I
still don't get:

> +	case HDA_FIXUP_ACT_INIT:
> +		alc_write_coef_idx(codec, 0x19, 0xa054);
> +		msleep(80);
> +		snd_hda_codec_write(codec, hp_pin, 0,
> +			    AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE);

Why this unconditional unmute is required for fixing the mic problem?


Takashi