From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40EEAC433E0 for ; Tue, 19 Jan 2021 15:49:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0689B208D5 for ; Tue, 19 Jan 2021 15:49:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391131AbhASPta (ORCPT ); Tue, 19 Jan 2021 10:49:30 -0500 Received: from mx2.suse.de ([195.135.220.15]:47890 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731601AbhASPtJ (ORCPT ); Tue, 19 Jan 2021 10:49:09 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0B964AC4F; Tue, 19 Jan 2021 15:48:23 +0000 (UTC) Date: Tue, 19 Jan 2021 16:48:22 +0100 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: tiwai@suse.com, "Kenneth R . Crudup" , Jaroslav Kysela , Ranjani Sridharan , Kai Vehmanen , Pierre-Louis Bossart , Mark Brown , Harsha Priya , Randy Dunlap , alsa-devel@alsa-project.org (moderated list:SOUND), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH v2] ALSA: hda: Balance runtime/system PM if direct-complete is disabled In-Reply-To: <20210119152145.346558-1-kai.heng.feng@canonical.com> References: <20210119152145.346558-1-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Jan 2021 16:21:43 +0100, Kai-Heng Feng wrote: > > After hibernation, HDA controller can't be runtime-suspended after > commit 215a22ed31a1 ("ALSA: hda: Refactor codjc PM to use > direct-complete optimization"), which enables direct-complete for HDA > codec. > > The HDA codec driver didn't expect direct-complete will be disabled > after it returns a positive value from prepare() callback. However, > there are some places that PM core can disable direct-complete. For > instance, system hibernation or when codec has subordinates like LEDs. > > So if the codec is prepared for direct-complete but PM core still calls > codec's suspend or freeze callback, partially revert the commit and take > the original approach, which uses pm_runtime_force_*() helpers to > ensure PM refcount are balanced. Meanwhile, still keep prepare() and > complete() callbacks to enable direct-complete and request a resume for > jack detection, respectively. > > Reported-by: Kenneth R. Crudup > Fixes: 215a22ed31a1 ("ALSA: hda: Refactor codec PM to use direct-complete optimization") > Signed-off-by: Kai-Heng Feng > --- > v2: > - Use pm_runtime_force_*() helpers to avoid suspend/resume ping pong. Thanks, applied now. Takashi