From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C46FC433E1 for ; Tue, 25 Aug 2020 07:27:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F4C420706 for ; Tue, 25 Aug 2020 07:27:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729460AbgHYH1q (ORCPT ); Tue, 25 Aug 2020 03:27:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:56030 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729209AbgHYH1p (ORCPT ); Tue, 25 Aug 2020 03:27:45 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 51AE1AC24; Tue, 25 Aug 2020 07:28:15 +0000 (UTC) Date: Tue, 25 Aug 2020 09:27:44 +0200 Message-ID: From: Takashi Iwai To: Tong Zhang Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: ca0106: fix error code handling In-Reply-To: <20200824224541.1260307-1-ztong0001@gmail.com> References: <20200824224541.1260307-1-ztong0001@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Aug 2020 00:45:41 +0200, Tong Zhang wrote: > > snd_ca0106_spi_write() returns 1 on error, snd_ca0106_pcm_power_dac() > is returning the error code directly, and the caller is expecting an > negative error code > > Signed-off-by: Tong Zhang Thanks, applied with Cc to stable. Takashi