From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E93FC3A59F for ; Mon, 26 Aug 2019 16:12:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 402D72173E for ; Mon, 26 Aug 2019 16:12:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732360AbfHZQMh (ORCPT ); Mon, 26 Aug 2019 12:12:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:33222 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729338AbfHZQMg (ORCPT ); Mon, 26 Aug 2019 12:12:36 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9DEDAAFFA; Mon, 26 Aug 2019 16:12:34 +0000 (UTC) Date: Mon, 26 Aug 2019 18:12:32 +0200 Message-ID: From: Takashi Iwai To: "Sudo Kamikaze" Cc: "alsa-devel@alsa-project.org" , ManuelReinhardt , Tony Das , Olek Poplavsky , Sasha Levin , Linus Walleij , Thomas Gleixner , Jaroslav Kysela , Sudokamikaze , Jussi Laako , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ALSA: usb-audio: Add Hiby R3 to quirks for native DSD support In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Aug 2019 18:05:05 +0200, Sudo Kamikaze wrote: > > From: Sudokamikaze > > This patch adds quirk VID/PID IDs for Hiby R3 portable DSD player DSD support > > Signed-off-by: Sudokamikaze > --- > sound/usb/quirks.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c > index 78858918cbc1..f90418149e4e 100644 > --- a/sound/usb/quirks.c > +++ b/sound/usb/quirks.c > @@ -1588,6 +1588,12 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip, > if (fp->altsetting == 2) > return SNDRV_PCM_FMTBIT_DSD_U32_BE; > break; > + > + /* ESS Sabre based USB DACs */ > + case USB_ID(0xc502, 0x0051): /* Hiby R3 */ > + if (fp->altsetting == 4) > + return SNDRV_PCM_FMTBIT_DSD_U32_BE; > + break; Is fp->dsd_raw set for your device? IOW, instead of adding an individual entry here, adding the vendor 0xc502 with fp->dsd_raw check like below would work? thanks, Takashi --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1658,6 +1658,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip, case 0x152a: /* Thesycon devices */ case 0x25ce: /* Mytek devices */ case 0x2ab6: /* T+A devices */ + case 0xc502: /* ESS Sabre */ if (fp->dsd_raw) return SNDRV_PCM_FMTBIT_DSD_U32_BE; break;