From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63881C04AB6 for ; Tue, 28 May 2019 05:25:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30EA42070D for ; Tue, 28 May 2019 05:25:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727282AbfE1FZM (ORCPT ); Tue, 28 May 2019 01:25:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:35392 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726305AbfE1FZM (ORCPT ); Tue, 28 May 2019 01:25:12 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 72FC2AF86; Tue, 28 May 2019 05:25:10 +0000 (UTC) Date: Tue, 28 May 2019 07:25:10 +0200 Message-ID: From: Takashi Iwai To: Luis Chamberlain Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] firmware: Add support for loading compressed files In-Reply-To: <20190520092647.8622-1-tiwai@suse.de> References: <20190520092647.8622-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 May 2019 11:26:42 +0200, Takashi Iwai wrote: > > Hi, > > this is a patch set to add the support for loading compressed firmware > files. > > The primary motivation is to reduce the storage size; e.g. currently > the amount of /lib/firmware on my machine counts up to 419MB, and this > can be reduced to 130MB file compression. No bad deal. > > The feature adds only fallback to the compressed file, so it should > work as it was as long as the normal firmware file is present. The > f/w loader decompresses the content, so that there is no change needed > in the caller side. > > Currently only XZ format is supported. A caveat is that the kernel XZ > helper code supports only CRC32 (or none) integrity check type, so > you'll have to compress the files via xz -C crc32 option. > > The patch set begins with a few other improvements and refactoring, > followed by the compression support. > > In addition to this, dracut needs a small fix to deal with the *.xz > files. > > Also, the latest patchset is found in topic/fw-decompress branch of my > sound.git tree: > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git > > > thanks, > > Takashi Luis, any comments on the patchset? thanks, Takashi > > === > > Takashi Iwai (5): > firmware: Free temporary page table after vmapping > firmware: Unify the paged buffer release helper > firmware: Use kvmalloc for page tables > firmware: Factor out the paged buffer handling code > firmware: Add support for loading compressed files > > drivers/base/firmware_loader/Kconfig | 18 +++ > drivers/base/firmware_loader/fallback.c | 63 ++-------- > drivers/base/firmware_loader/firmware.h | 16 ++- > drivers/base/firmware_loader/main.c | 212 +++++++++++++++++++++++++++++--- > 4 files changed, 235 insertions(+), 74 deletions(-) > > -- > 2.16.4 >