From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933021AbeBLIJN (ORCPT <rfc822;w@1wt.eu>);
        Mon, 12 Feb 2018 03:09:13 -0500
Received: from mx2.suse.de ([195.135.220.15]:33428 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932999AbeBLII4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 12 Feb 2018 03:08:56 -0500
Date: Mon, 12 Feb 2018 09:08:54 +0100
Message-ID: <s5hinb2aauh.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Kirill Marinushkin <k.marinushkin@gmail.com>
Cc: perex@perex.cz, alsa-devel@alsa-project.org,
        Stephen Barber <smbarber@chromium.org>,
        Bhumika Goyal <bhumirks@gmail.com>,
        Jaejoong Kim <climbbb.kim@gmail.com>, Julian Scheel <julian@jusst.de>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Fix UAC2 get_ctl request with a RANGE attribute
In-Reply-To: <40196230-8f73-4cca-08e5-d67bfbea2d6e@gmail.com>
References: <20180129053755.20136-1-k.marinushkin@gmail.com>
        <s5hvaf95p4i.wl-tiwai@suse.de>
        <40196230-8f73-4cca-08e5-d67bfbea2d6e@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 08 Feb 2018 07:21:36 +0100,
Kirill Marinushkin wrote:
> 
> On 02/07/18 06:45, Takashi Iwai wrote:
> > On Mon, 29 Jan 2018 06:37:55 +0100,
> > Kirill Marinushkin wrote:
> >> The layout of the UAC2 Control request and response varies depending on
> >> the request type. With the current implementation, only the Layout 2
> >> Parameter Block (with the 2-byte sized RANGE attribute) is handled
> >> properly. For the Control requests with the 1-byte sized RANGE attribute
> >> (Bass Control, Mid Control, Tremble Control), the response is parsed
> >> incorrectly.
> >>
> >> This commit:
> >> * fixes the wLength field value in the request
> >> * fixes parsing the range values from the response
> >>
> >> Fixes: 23caaf19b11e ("ALSA: usb-mixer: Add support for Audio Class v2.0")
> >> Signed-off-by: Kirill Marinushkin <k.marinushkin@gmail.com>
> >> Cc: Jaroslav Kysela <perex@perex.cz>
> >> Cc: Takashi Iwai <tiwai@suse.com>
> >> Cc: Jaejoong Kim <climbbb.kim@gmail.com>
> >> Cc: Bhumika Goyal <bhumirks@gmail.com>
> >> Cc: Stephen Barber <smbarber@chromium.org>
> >> Cc: Julian Scheel <julian@jusst.de>
> >> Cc: alsa-devel@alsa-project.org
> >> Cc: linux-kernel@vger.kernel.org
> > Sorry for the late reply, as I've been (and still) off.
> >
> > Does this bug actually hit on any real devices, or is it only a
> > logical error so far?  In the former case, a Cc to stable is
> > mandatory.
> >
> > In anyway, I'll review and merge it properly once after I back to
> > work.
> >
> >
> > thanks,
> >
> > Takashi
> 
> Hello Takashi,
> 
> Thank you for your answer. I will wait until you are back to work, don't 
> worry about the late replies.
> 
> I did not hit the issue on a real device.
> 
> During my UAC2 experiments, I reproduced this issue on the development 
> board, and then tested my solution on it.

OK, if it happened on a development system, it's a real issue, and we
should put Cc to stable.  Now I applied the patch.

Thanks!


Takashi