From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753326Ab3AKKRq (ORCPT ); Fri, 11 Jan 2013 05:17:46 -0500 Received: from cantor2.suse.de ([195.135.220.15]:54175 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751954Ab3AKKRo (ORCPT ); Fri, 11 Jan 2013 05:17:44 -0500 Date: Fri, 11 Jan 2013 11:17:43 +0100 Message-ID: From: Takashi Iwai To: Jens Axboe Cc: Eldad Zack , perex@perex.cz, alsa-devel@alsa-project.org, "linux-kernel@vger.kernel.org" Subject: Re: Oops in sound/usb/pcm.c:match_endpoint_audioformats() in current -git In-Reply-To: <50EFC38D.80306@kernel.dk> References: <50EE7A94.60409@kernel.dk> <50EEB8D2.2030702@kernel.dk> <50EFC38D.80306@kernel.dk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 11 Jan 2013 08:47:25 +0100, Jens Axboe wrote: > > On 2013-01-10 21:19, Takashi Iwai wrote: > > From: Takashi Iwai > > Subject: [PATCH v2] ALSA: usb-audio: Fix NULL dereference by access to > > non-existing substream > > > > The commit [0d9741c0: ALSA: usb-audio: sync ep init fix for > > audioformat mismatch] introduced the correction of parameters to be > > set for sync EP. But since the new code assumes that the sync EP is > > always paired with the data EP of another direction, it triggers Oops > > when a device only with a single direction is used. > > > > This patch adds a proper check of sync EP type and the presence of the > > paired substream for avoiding the crash. > > > > Reported-by: Jens Axboe > > Signed-off-by: Takashi Iwai > > Confirmed, it works. You can add my tested-by too. Thanks Takashi! Thanks for quick testing. Applied it now. Takashi