From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752987AbZLBLiE (ORCPT ); Wed, 2 Dec 2009 06:38:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751192AbZLBLiD (ORCPT ); Wed, 2 Dec 2009 06:38:03 -0500 Received: from cantor.suse.de ([195.135.220.2]:52850 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbZLBLiD (ORCPT ); Wed, 2 Dec 2009 06:38:03 -0500 Date: Wed, 02 Dec 2009 12:38:07 +0100 Message-ID: From: Takashi Iwai To: mgross@linux.intel.com Cc: linux-pm , lkml , perex@perex.cz, alsa-devel@alsa-project.org Subject: Re: [PATCH]PM_QOS-to-use-handle-based-requests-pcm-update 5/5 In-Reply-To: <20091201213840.GE19688@linux.intel.com> References: <20091201213840.GE19688@linux.intel.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 1 Dec 2009 13:38:40 -0800, mark gross wrote: > > --- a/sound/core/pcm_native.c > +++ b/sound/core/pcm_native.c (snip) > @@ -506,8 +508,8 @@ static int snd_pcm_hw_free(struct snd_pcm_substream *substream) > if (substream->ops->hw_free) > result = substream->ops->hw_free(substream); > runtime->status->state = SNDRV_PCM_STATE_OPEN; > - pm_qos_remove_requirement(PM_QOS_CPU_DMA_LATENCY, > - substream->latency_id); > + pm_qos_remove_request(substream->latency_pm_qos_req); The NULL check seems needed in the caller side because pm_qos_remove_request() doesn't do it. Or, would you add a NULL check in pm_qos_remove_request()? It'd be more handy. thanks, Takashi