From: Takashi Iwai <tiwai@suse.de>
To: Kyle McMartin <kyle@infradead.org>
Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] module: kzalloc mod->ref
Date: Wed, 14 Jan 2009 17:25:31 +0100 [thread overview]
Message-ID: <s5hiqoh7t38.wl%tiwai@suse.de> (raw)
In-Reply-To: <20090114155859.GO25103@bombadil.infradead.org>
At Wed, 14 Jan 2009 10:58:59 -0500,
Kyle McMartin wrote:
>
> On Wed, Jan 14, 2009 at 10:09:59AM +0100, Takashi Iwai wrote:
> > At Tue, 13 Jan 2009 22:35:33 -0500,
> > Kyle McMartin wrote:
> > >
> > > From: Kyle McMartin <kyle@redhat.com>
> > >
> > > Dynamically allocate mod->ref instead of fixing it in the struct module.
> > > Reduces on disk space wasted in the module .ko, and kills a loop
> > > initializing the local_t it contains since we can just kzalloc it.
> > >
> > > This matters when we're talking about large NR_CPUS.
> > >
> > > Signed-off-by: Kyle McMartin <kyle@redhat.com>
> > > ---
> > > The patch removing cacheline_aligned from struct module_ref should be
> > > applied as well to cut down on the amount of memory we allocate. This
> > > patch makes a nice stopgap until we have per_cpu module references.
> > >
> > > cheers, Kyle
> >
> > Similar patches (including mine) have been already posted, but no
> > proceed until now...
> > http://lkml.org/lkml/2008/11/11/315
>
> Ah, sigh.
>
> It would be nice to get this sorted out, since we're serious wasting
> disk space for no good reason...
>
> Although as Richard points out, dropping the cacheline_aligned might
> drop networking performance (which, sigh, is also stupid) but allocating
> 128b * NR_CPUS is just a ridiculous amount of memory to waste for a
> reference count...
We can use nr_cpu_ids instead of NR_CPUS.
For a machine like 4096 CPUs, such an amount of memory is like a
peanut :)
Takashi
next prev parent reply other threads:[~2009-01-14 16:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 3:35 Kyle McMartin
2009-01-14 5:54 ` [PATCHv2] " Kyle McMartin
2009-01-14 9:09 ` [PATCH] " Takashi Iwai
2009-01-14 15:58 ` Kyle McMartin
2009-01-14 16:25 ` Takashi Iwai [this message]
2009-01-14 19:29 ` Valdis.Kletnieks
2009-01-14 20:37 ` Takashi Iwai
2009-01-14 20:53 ` Kyle McMartin
2009-01-14 17:51 ` richard kennedy
2009-01-14 18:17 ` Kyle McMartin
[not found] ` <200901151303.20006.rusty@rustcorp.com.au>
2009-01-25 15:52 ` Richard Kennedy
[not found] ` <200901151521.47326.rusty@rustcorp.com.au>
2009-01-15 6:03 ` Kyle McMartin
[not found] ` <200901261751.21817.rusty@rustcorp.com.au>
2009-01-27 1:36 ` Rusty Russell
2009-01-27 1:58 ` Tejun Heo
2009-01-27 13:15 ` Ingo Molnar
2009-01-28 12:24 ` Rusty Russell
2009-01-14 10:15 ` richard kennedy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hiqoh7t38.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=kyle@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®