From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B7A4C433EF for ; Mon, 11 Apr 2022 07:41:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245591AbiDKHnc (ORCPT ); Mon, 11 Apr 2022 03:43:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245574AbiDKHn0 (ORCPT ); Mon, 11 Apr 2022 03:43:26 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77F645F70 for ; Mon, 11 Apr 2022 00:41:07 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 73A9C1F37D; Mon, 11 Apr 2022 07:41:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1649662866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jn50J4OXXzYzRftzsfTWnK2V/NAvOb/ccwOAXbOa7rA=; b=B32e+ZkDqLxKQiB82LhRcriS4BBbCsRbQ7CBAowvjDo8cXZj0bTnjc3lVJCRtLOZqfWoT9 eN5zyYwtxd/waVVDEWP72KupUrEqzbwLmQvP7sIaQZ9cw3ycQDqqzKpmU8gKmeN0DkngFZ 7gdyPUgFZXalitHmc5y/l7x/KFv5F9g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1649662866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jn50J4OXXzYzRftzsfTWnK2V/NAvOb/ccwOAXbOa7rA=; b=yBcd7j5JQW03huMKC4RdjnrINErxiruAZuh9oVX2QkaMsxZvmIao1e0qPl8wB0M9QtM6iw vu6H+km8NWzCrsBA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 6B7AEA3BA9; Mon, 11 Apr 2022 07:41:06 +0000 (UTC) Date: Mon, 11 Apr 2022 09:41:06 +0200 Message-ID: From: Takashi Iwai To: Zheyu Ma Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, Linux Kernel Mailing List Subject: Re: [BUG] ALSA: echoaudio: warning when the driver fails to probe In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 10 Apr 2022 11:13:55 +0200, Zheyu Ma wrote: > > Hello, > > I found a bug in echoaudio.c. > When the driver fails at the function snd_echo_create(), it should > release resources requested before, otherwise we will get the > following warning: > > [ 3.262866] remove_proc_entry: removing non-empty directory > 'irq/21', leaking at least 'snd_indigodj' > [ 3.263577] WARNING: CPU: 3 PID: 261 at fs/proc/generic.c:717 > remove_proc_entry+0x389/0x3f0 > [ 3.267098] RIP: 0010:remove_proc_entry+0x389/0x3f0 > [ 3.269976] Call Trace: > [ 3.269979] > [ 3.269988] unregister_irq_proc+0x14c/0x170 > [ 3.269997] irq_free_descs+0x94/0xe0 > [ 3.270004] mp_unmap_irq+0xb6/0x100 > [ 3.270011] acpi_unregister_gsi_ioapic+0x27/0x40 > [ 3.270017] acpi_pci_irq_disable+0x1d3/0x320 > [ 3.270025] pci_disable_device+0x1ad/0x380 > [ 3.270034] pcim_release+0x566/0x6d0 > [ 3.270046] devres_release_all+0x1f1/0x2c0 > [ 3.270057] really_probe+0xe0/0x920 Could you try the patch below? thanks, Takashi --- --- a/sound/pci/echoaudio/echoaudio.c +++ b/sound/pci/echoaudio/echoaudio.c @@ -1906,9 +1906,6 @@ static int snd_echo_create(struct snd_card *card, pci_write_config_byte(pci, PCI_LATENCY_TIMER, 0xC0); - err = pcim_enable_device(pci); - if (err < 0) - return err; pci_set_master(pci); /* Allocate chip if needed */ @@ -1987,6 +1984,10 @@ static int snd_echo_probe(struct pci_dev *pci, return -ENOENT; } + err = pcim_enable_device(pci); + if (err < 0) + return err; + i = 0; err = snd_devm_card_new(&pci->dev, index[dev], id[dev], THIS_MODULE, sizeof(*chip), &card);