mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Christian Lachner <gladiac@gmail.com>
Cc: perex@perex.cz, tiwai@suse.com, kailang@realtek.com,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master after reboot from Windows
Date: Fri, 31 Dec 2021 18:14:26 +0100	[thread overview]
Message-ID: <s5hk0fkofwt.wl-tiwai@suse.de> (raw)
In-Reply-To: <20211231102138.3226-2-gladiac@gmail.com>

On Fri, 31 Dec 2021 11:21:38 +0100,
Christian Lachner wrote:
> 
> +static void alc1220_fixup_gb_x570(struct hda_codec *codec,
> +				     const struct hda_fixup *fix,
> +				     int action)
> +{
> +	static const hda_nid_t conn1[] = { 0x0c };
> +
> +	if (action != HDA_FIXUP_ACT_PRE_PROBE)
> +		return;
> +
> +	alc_write_coef_idx(codec, 0x1a, 0x01c1);
> +	alc_write_coef_idx(codec, 0x1b, 0x0202);
> +	alc_write_coef_idx(codec, 0x43, 0x3005);
> +	alc_write_coef_idx(codec, 0x58, 0x8fd6);
> +	alc_write_coef_idx(codec, 0x5f, 0xa3c5);
> +	alc_write_coef_idx(codec, 0x6a, 0x0232);

Those could be better with struct coef_fw table to be processed via
alc_process_coef_fw().

Also the coef update needs to be performed not only at PRE_INIT but
also at each resume, so this should be better done for action ==
HDA_FIXUP_ACT_INIT, I suppose.


thanks,

Takashi

      reply	other threads:[~2021-12-31 17:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-31 10:21 [PATCH 0/1] " Christian Lachner
2021-12-31 10:21 ` [PATCH 1/1] " Christian Lachner
2021-12-31 17:14   ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hk0fkofwt.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=gladiac@gmail.com \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®