mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Xiaoke Wang <xkernel.wang@foxmail.com>
Cc: joe@perches.com, perex@perex.cz, tiwai@suse.com,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: jack: Check the return value of kstrdup()
Date: Mon, 13 Dec 2021 10:40:31 +0100	[thread overview]
Message-ID: <s5hk0g8etbk.wl-tiwai@suse.de> (raw)
In-Reply-To: <tencent_094816F3522E0DC704056C789352EBBF0606@qq.com>

On Mon, 13 Dec 2021 08:39:31 +0100,
Xiaoke Wang wrote:
> 
> kstrdup() can return NULL, it is better to check the return value of it.
> Fix: free jack and use my full name.
> 
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>

Thanks, applied now with Cc-to-stable.

BTW, when you submit a revised patch, please put 'v2' or such to the
patch subject prefix, e.g.
  [PATCH v2] ALSA: jack: ...

Also you can put the note about the changes between revisions as

  v1->v2: Fix something more....

and this could be put after the first '---' line (around the diffstat)
if it's not necessarily to be included in the final commit log.


Takashi

  reply	other threads:[~2021-12-13  9:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13  7:39 Xiaoke Wang
2021-12-13  9:40 ` Takashi Iwai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-12-11 17:13 xkernel
2021-12-12  5:44 ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hk0g8etbk.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=xkernel.wang@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®