mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jonas Hahnfeld <hahnjo@hahnjo.de>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Add quirk for VF0770
Date: Tue, 12 Oct 2021 11:04:29 +0200	[thread overview]
Message-ID: <s5hk0ii397m.wl-tiwai@suse.de> (raw)
In-Reply-To: <27189cfac466b244e176f3098409204fc67a2a8d.camel@hahnjo.de>

On Mon, 11 Oct 2021 19:12:56 +0200,
Jonas Hahnfeld wrote:
> 
> Am Sonntag, dem 10.10.2021 um 22:26 +0200 schrieb Takashi Iwai:
> > On Sun, 10 Oct 2021 13:19:47 +0200,
> > Jonas Hahnfeld wrote:
> > > 
> > > The device advertises 8 formats, but only a rate of 48kHz is honored
> > > by the hardware and 24 bits give chopped audio, so only report the
> > > one working combination. This fixes out-of-the-box audio experience
> > > with PipeWire which otherwise attempts to choose S24_3LE (while
> > > PulseAudio defaulted to S16_LE).
> > > 
> > > Signed-off-by: Jonas Hahnfeld <hahnjo@hahnjo.de>
> > 
> > Could you give alsa-info.sh output with and without patch, just for
> > comparison?  Run the script with --no-upload option and attach the
> > outputs.
> 
> Attached. Let me know if I should put any of this into the commit
> message.

Thanks.  The device is a UAC1, so the format quirk seems to be a valid
way.

But I found the terminator entry (.ifnum = -1) is missing in the
QUIRK_COMPOSITE array.  Could you resubmit with the fix?


thanks,

Takashi

  reply	other threads:[~2021-10-12  9:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-10 11:19 Jonas Hahnfeld
2021-10-10 20:26 ` Takashi Iwai
2021-10-11 17:12   ` Jonas Hahnfeld
2021-10-12  9:04     ` Takashi Iwai [this message]
2021-10-12 20:09       ` [PATCH v2] " Jonas Hahnfeld
2021-10-12 20:14         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hk0ii397m.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=hahnjo@hahnjo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®