From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0402C433DB for ; Thu, 11 Mar 2021 14:28:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CC8664FE2 for ; Thu, 11 Mar 2021 14:28:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232709AbhCKO2L (ORCPT ); Thu, 11 Mar 2021 09:28:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:51310 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233300AbhCKO2B (ORCPT ); Thu, 11 Mar 2021 09:28:01 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DFF9EAC16; Thu, 11 Mar 2021 14:27:59 +0000 (UTC) Date: Thu, 11 Mar 2021 15:27:59 +0100 Message-ID: From: Takashi Iwai To: Andy Shevchenko Cc: Andy Shevchenko , ALSA Development Mailing List , Linux Kernel Mailing List , Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH v1 1/1] ALSA: hda/realtek: Sort alphanumerically the SND_PCI_QUIRK() entries. In-Reply-To: References: <20210311132741.80989-1-andriy.shevchenko@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Mar 2021 15:22:22 +0100, Andy Shevchenko wrote: > > On Thu, Mar 11, 2021 at 3:40 PM Takashi Iwai wrote: > > On Thu, 11 Mar 2021 14:27:41 +0100, > > Andy Shevchenko wrote: > > > > > > Sort alphanumerically the SND_PCI_QUIRK() entries for better maintenance. > > > No functional change implied. > > > > I'd love to apply this kind of cleanups (and I do sometimes > > partially), but practically seen, this may make the stable backporting > > significantly harder because many quirk patches are backported to the > > very old LTS kernels. So, unless any specific reason (e.g. some > > entries doubled or wrongly applied) is given, I'd avoid this full > > plastic surgery. > > Btw, can we apply the hunks that are against the lines under #if 0? > At least it will reduce the chaos rate in the file w/o worrying that > people will add entries there to backport. If the #if-0-block causes a problem, we can drop it, too. There are two big ones, and those have been disabled for almost a decade already, so it's quite safe to drop them. Takashi