From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B12CFC433E1 for ; Tue, 25 Aug 2020 15:03:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D2E82075F for ; Tue, 25 Aug 2020 15:03:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726752AbgHYPDV (ORCPT ); Tue, 25 Aug 2020 11:03:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:52658 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726570AbgHYPDT (ORCPT ); Tue, 25 Aug 2020 11:03:19 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8602FADDB; Tue, 25 Aug 2020 15:03:49 +0000 (UTC) Date: Tue, 25 Aug 2020 17:03:18 +0200 Message-ID: From: Takashi Iwai To: Adrien Crivelli Cc: Alex Dewar , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches In-Reply-To: References: <7210c752-0a1f-3985-91f0-b70facf0293c@gmail.com> <30693624-744d-6971-1dc8-8ffe4df6082c@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Aug 2020 16:36:13 +0200, Adrien Crivelli wrote: > > [1 ] > > I believe the code is correct (even though the diff is confusing), but I can > edit the commit message to also mention the model name. > > Should I submit the patch here as a reply ? or should I create a brand new > submission in a new thread ? In a new thread please. thanks, Takashi > > On Tue, 25 Aug 2020 at 17:00, Takashi Iwai wrote: > > On Mon, 24 Aug 2020 14:31:17 +0200, > Alex Dewar wrote: > > > > My mistake -- I didn't read your changelog properly. Sorry! > > Would you resubmit the corrected fix patch? > > Also, better to indicate the device id number in the patch > description.  It's confusing which entry you've corrected > intentionally for what, and documenting it would help understanding > it. > > thanks, > > Takashi > > > > > On 24/08/2020 13:30, Alex Dewar wrote: > > > There's a mistake in this. The ID numbers are the wrong way round. > > > > > > Alex > > > >