From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D977EC433DF for ; Mon, 3 Aug 2020 14:41:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6D2820825 for ; Mon, 3 Aug 2020 14:41:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728046AbgHCOld (ORCPT ); Mon, 3 Aug 2020 10:41:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:34624 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726622AbgHCOld (ORCPT ); Mon, 3 Aug 2020 10:41:33 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 227CCAF16; Mon, 3 Aug 2020 14:41:47 +0000 (UTC) Date: Mon, 03 Aug 2020 16:41:31 +0200 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: tiwai@suse.com, Jaroslav Kysela , Hui Peng , Andrew Oakley , Chris Boyle , Alexander Tsoy , Dmitry Panchenko , Gregor Pintar , Ard van Breemen , Hector Martin , =?UTF-8?B?RnJhbnRpxaFl?= =?UTF-8?B?ayBLdcSNZXJh?= , alsa-devel@alsa-project.org (moderated list:SOUND), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH] ALSA: usb-audio: Add support for Lenovo ThinkStation P620 In-Reply-To: <20200803142612.17156-1-kai.heng.feng@canonical.com> References: <20200803142612.17156-1-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 03 Aug 2020 16:26:08 +0200, Kai-Heng Feng wrote: > > Lenovo ThinkStation P620 is like other TRX40 boards, is equipped with > two USB audio cards. > > USB device (17aa:104d) provides functionality for Internal Speaker and > Front Headset. It's UAC v2, so it supports insertion control (jack > detection). However, when trying to get the connector status of the > speaker, an error occurs: > [ 5.787405] usb 3-1: cannot get connectors status: req = 0x81, wValue = 0x200, wIndex = 0x1000, type = 0 > > Since the insertion control works perfectly for the headset, the error > for speaker is probably casued by connecting internally. So let's relax > the error for a bit if it's a speaker, and always reports it's connected. > > USB device (17aa:1046) is for rear Line-in, Line-out and Microphone. > The insertion control works for all three jacks. However, there's an > Function Unit that doesn't work: > [ 5.905415] usb 3-6: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 > [ 5.905418] usb 3-6: 19:0: cannot get min/max values for control 12 (id 19) > > So turn off the FU to avoid the error. > > Also, add specific card name for both devices, so userspace can easily > indentify both cards. > > Signed-off-by: Kai-Heng Feng Thanks, applied. Takashi