From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA771C04E53 for ; Wed, 15 May 2019 13:11:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3BE220843 for ; Wed, 15 May 2019 13:11:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727427AbfEONLo (ORCPT ); Wed, 15 May 2019 09:11:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:34838 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725977AbfEONLo (ORCPT ); Wed, 15 May 2019 09:11:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E9ECAABC1; Wed, 15 May 2019 13:11:42 +0000 (UTC) Date: Wed, 15 May 2019 15:11:42 +0200 Message-ID: From: Takashi Iwai To: "Ayman Bagabas" Cc: , "Hui Wang" , "Chris Chiu" , "Daniel Drake" , "Jian-Hong Pan" , "Andy Shevchenko" , "Darren Hart" , "Jaroslav Kysela" , "Kailang Yang" , , Subject: Re: [PATCH v1 2/2] sound: Enable micmute led for Huawei laptops In-Reply-To: <20190513203009.28686-3-ayman.bagabas@gmail.com> References: <20190513203009.28686-1-ayman.bagabas@gmail.com> <20190513203009.28686-3-ayman.bagabas@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 May 2019 22:30:06 +0200, Ayman Bagabas wrote: > > Since this LED is found on huawei laptops, we can hook it to > huawei-wmi platform driver which uses the common WMI interface present > in these laptops to control the LED. > > I've also made some renames and used product name instead of common name > to avoid confusion. > > Signed-off-by: Ayman Bagabas This looks applicable independently from the patch 1? If so, it can go via sound git tree while another via x86-platform tree. thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 42cd3945e0de..3661470766ba 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5684,7 +5684,7 @@ enum { > ALC298_FIXUP_TPT470_DOCK, > ALC255_FIXUP_DUMMY_LINEOUT_VERB, > ALC255_FIXUP_DELL_HEADSET_MIC, > - ALC256_FIXUP_HUAWEI_MBXP_PINS, > + ALC256_FIXUP_HUAWEI_MACH_WX9_PINS, > ALC295_FIXUP_HP_X360, > ALC221_FIXUP_HP_HEADSET_MIC, > ALC285_FIXUP_LENOVO_HEADPHONE_NOISE, > @@ -5975,7 +5975,7 @@ static const struct hda_fixup alc269_fixups[] = { > .chained = true, > .chain_id = ALC269_FIXUP_HEADSET_MIC > }, > - [ALC256_FIXUP_HUAWEI_MBXP_PINS] = { > + [ALC256_FIXUP_HUAWEI_MACH_WX9_PINS] = { > .type = HDA_FIXUP_PINS, > .v.pins = (const struct hda_pintbl[]) { > {0x12, 0x90a60130}, > @@ -6996,9 +6996,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), > SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K), > SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD), > - SND_PCI_QUIRK(0x19e5, 0x3200, "Huawei MBX", ALC255_FIXUP_MIC_MUTE_LED), > - SND_PCI_QUIRK(0x19e5, 0x3201, "Huawei MBX", ALC255_FIXUP_MIC_MUTE_LED), > - SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_MBXP_PINS), > + SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MACH-WX9", ALC256_FIXUP_HUAWEI_MACH_WX9_PINS), > SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */ > > #if 0 > @@ -7057,6 +7055,7 @@ static const struct snd_pci_quirk alc269_fixup_vendor_tbl[] = { > SND_PCI_QUIRK_VENDOR(0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED), > SND_PCI_QUIRK_VENDOR(0x104d, "Sony VAIO", ALC269_FIXUP_SONY_VAIO), > SND_PCI_QUIRK_VENDOR(0x17aa, "Thinkpad", ALC269_FIXUP_THINKPAD_ACPI), > + SND_PCI_QUIRK_VENDOR(0x19e5, "Huawei Matebook", ALC255_FIXUP_MIC_MUTE_LED), > {} > }; > > -- > 2.20.1 > >