From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB3B1C46475 for ; Tue, 23 Oct 2018 09:23:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83D9A20665 for ; Tue, 23 Oct 2018 09:23:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83D9A20665 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728572AbeJWRqE (ORCPT ); Tue, 23 Oct 2018 13:46:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:37692 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727714AbeJWRqE (ORCPT ); Tue, 23 Oct 2018 13:46:04 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3AD28AE67; Tue, 23 Oct 2018 09:23:30 +0000 (UTC) Date: Tue, 23 Oct 2018 11:23:29 +0200 Message-ID: From: Takashi Iwai To: Linus Torvalds Cc: Boris Brezillon , Catalin Marinas , Christoph Hellwig , Guenter Roeck , Jacek Anaszewski , Jens Axboe , Linus Walleij , Mark Brown , Ulf Hansson , Greg KH , Linux Kernel Mailing List , Willy Tarreau Subject: Re: Git pull ack emails.. In-Reply-To: <20181023090245.GC23341@1wt.eu> References: <20181023090245.GC23341@1wt.eu> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Oct 2018 11:02:45 +0200, Willy Tarreau wrote: > > On Tue, Oct 23, 2018 at 09:41:32AM +0100, Linus Torvalds wrote: > > Because yes, the second option likely works fine in most cases, but my > > pull might not actually be final *if* something goes bad (where bad > > might be just "oops, my tests showed a semantic conflict, I'll need to > > fix up my merge" to "I'm going to have to look more closely at that > > warning" to "uhhuh, I'm going to just undo the pull entirely because > > it ended up being broken"). > > Is that a big problem ? I mean probably those who need an ACK just want > to be sure their PR was not lost between them and you. It's not a guarantee > that the code will be kept till the release anyway, and I tend to think > that changing your mind after attempting a build is not different than > changing your mind 3 days later. So when this happens, you're possibly > expected to simply notify the author later saying "sorry, I changed my > mind and finally I dropped your code for this or that reason". That > should be enough to cover the vast majority of use cases, no ? Agreed, the ACK mail doesn't necessarily mean that everything right, but just ACK that the pull request is being processed. The e-mail communication can go wrong pretty easily (happened once or twice for my past PR's), so a simple ACK would relieve me wrt that point -- as Greg's ACK did indeed. thanks, Takashi