From: Takashi Iwai <tiwai@suse.de>
To: "Philipp Klocke" <philipp97kl@gmail.com>
Cc: <lukas.bulwahn@gmail.com>, "Jaroslav Kysela" <perex@perex.cz>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [sound/i2c/cs8427] Fix int to char conversion
Date: Thu, 18 Oct 2018 15:46:20 +0200 [thread overview]
Message-ID: <s5hk1mftljn.wl-tiwai@suse.de> (raw)
In-Reply-To: <20181018103303.30226-1-philipp97kl@gmail.com>
On Thu, 18 Oct 2018 12:33:02 +0200,
Philipp Klocke wrote:
>
> Compiling with clang yields the following warning:
>
> sound/i2c/cs8427.c:140:31: warning: implicit conversion from 'int'
> to 'char' changes value from 160 to -96 [-Wconstant-conversion]
> data[0] = CS8427_REG_AUTOINC | CS8427_REG_CORU_DATABUF;
> ~ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Because CS8427_REG_AUTOINC is defined as 128, it is too big for a
> char field.
> So change data from char to unsigned char, that it can hold the value.
>
> This patch does not change the generated code.
>
> Signed-off-by: Philipp Klocke <philipp97kl@gmail.com>
Applied, thanks.
But at the next time, please put the relevant subsystem MLs to Cc,
and use the proper subject prefix (depending on the subsystem).
Takashi
next prev parent reply other threads:[~2018-10-18 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 10:33 Philipp Klocke
2018-10-18 13:46 ` Takashi Iwai [this message]
[not found] ` <CAGZ+4_KdtsmuvrtmSnt729xCs1W4s+O+7hXS-D7gVc5+4W+ThQ@mail.gmail.com>
2018-10-18 13:55 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk1mftljn.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=perex@perex.cz \
--cc=philipp97kl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®