From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3210981-1518498292-2-5602264492318142570 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='de', MailFrom='org' X-Spam-charsets: plain='US-ASCII' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1518498291; b=MHVA8qOegm4dQ3jVaD9B7q1iKP1vd41sIqp2B/JxvEnhuvr bAH5/oiem9Vh3R9Ck6z+LkTwQV2y5WvIap6msglsjHGtI03SRhUnn9lkyTS/5lo2 MY+nCa8iU/EWOfLOlDlr6+csSnuClq65EVIe2uj3XKM9VQg1+pMhnG8tq69LhX0A ORSRVfEjzPhXPRKclfLWr04eN2rUPPXGXk0bHsDAw9nLCwtWjEoOfvJu2XcpZJu2 4ak2IG8WI1/WDPjozWBHVev1GKqTEZ/lrCGFemdHDDWB6CD2/hcGho3tnHkAXayx Q5odExtQauypQnMPMoJ+ZIk5yzsWWgzBsDLi+kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:message-id:from:to:cc:subject :in-reply-to:references:mime-version:content-type:sender :list-id; s=arctest; t=1518498291; bh=Nankpsxolo5dZO8twaWpKWtk3N ybUf6pWcwNvKjQDCk=; b=LHvOoDz5HknQn1x4oRMoocGditdqc2ckRQ3KzG9M4I j8q357Eq32TfW5SXmeIphnmfpuefyl9klN3aXSj8t6IQHajAz3unODF++XUuaplL MMOCgJ4xUYDwrX5VIQk5CCbJNeV56k52muwnUYdfP/H59yLdCUol9z0ogeWx5ri8 OF7CxNvmPrcx9t0EPSnt6xiCDtaH7NT8ttCTLVAKpNZwx0SfKT9kRCuOfiIy/Yws 2c+1Ze+66eoMe58/AtFn79udRq4W9pBROmCpUDe6eIhx6sLVnzMTfbcPV3ZVcibA rOLJNDNQ5GPv3MpZzJ5e4qwWGi1CCkDo35qLkSzXu5Ag== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=suse.de; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=suse.de header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=suse.de; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=suse.de header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751365AbeBMFEt (ORCPT ); Tue, 13 Feb 2018 00:04:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:56889 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160AbeBMFEs (ORCPT ); Tue, 13 Feb 2018 00:04:48 -0500 Date: Tue, 13 Feb 2018 06:04:45 +0100 Message-ID: From: Takashi Iwai To: Kirill Marinushkin Cc: perex@perex.cz, alsa-devel@alsa-project.org, Stephen Barber , Bhumika Goyal , Jaejoong Kim , Julian Scheel , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: Fix UAC2 get_ctl request with a RANGE attribute In-Reply-To: <120bc0f8-f472-268d-1247-3245ae994fe5@gmail.com> References: <20180129053755.20136-1-k.marinushkin@gmail.com> <40196230-8f73-4cca-08e5-d67bfbea2d6e@gmail.com> <120bc0f8-f472-268d-1247-3245ae994fe5@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, 12 Feb 2018 20:32:53 +0100, Kirill Marinushkin wrote: > > Hello maintainers of , > > > As discussed earlier in this thread, I propose this patch to stable. > > It fixes the issue, which exists since v2.6.34. It's already marked in the applied patch, so you don't need to ping stable kernel guys. thanks, Takashi > > > Best Regards, > > Kirill > > On 02/12/18 09:08, Takashi Iwai wrote: > > On Thu, 08 Feb 2018 07:21:36 +0100, > > Kirill Marinushkin wrote: > >> On 02/07/18 06:45, Takashi Iwai wrote: > >>> On Mon, 29 Jan 2018 06:37:55 +0100, > >>> Kirill Marinushkin wrote: > >>>> The layout of the UAC2 Control request and response varies depending on > >>>> the request type. With the current implementation, only the Layout 2 > >>>> Parameter Block (with the 2-byte sized RANGE attribute) is handled > >>>> properly. For the Control requests with the 1-byte sized RANGE attribute > >>>> (Bass Control, Mid Control, Tremble Control), the response is parsed > >>>> incorrectly. > >>>> > >>>> This commit: > >>>> * fixes the wLength field value in the request > >>>> * fixes parsing the range values from the response > >>>> > >>>> Fixes: 23caaf19b11e ("ALSA: usb-mixer: Add support for Audio Class v2.0") > >>>> Signed-off-by: Kirill Marinushkin > >>>> Cc: Jaroslav Kysela > >>>> Cc: Takashi Iwai > >>>> Cc: Jaejoong Kim > >>>> Cc: Bhumika Goyal > >>>> Cc: Stephen Barber > >>>> Cc: Julian Scheel > >>>> Cc: alsa-devel@alsa-project.org > >>>> Cc: linux-kernel@vger.kernel.org > >>> Sorry for the late reply, as I've been (and still) off. > >>> > >>> Does this bug actually hit on any real devices, or is it only a > >>> logical error so far? In the former case, a Cc to stable is > >>> mandatory. > >>> > >>> In anyway, I'll review and merge it properly once after I back to > >>> work. > >>> > >>> > >>> thanks, > >>> > >>> Takashi > >> Hello Takashi, > >> > >> Thank you for your answer. I will wait until you are back to work, don't > >> worry about the late replies. > >> > >> I did not hit the issue on a real device. > >> > >> During my UAC2 experiments, I reproduced this issue on the development > >> board, and then tested my solution on it. > > OK, if it happened on a development system, it's a real issue, and we > > should put Cc to stable. Now I applied the patch. > > > > Thanks! > > > > > > Takashi >