From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756251AbcIUMhr (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Sep 2016 08:37:47 -0400
Received: from mx2.suse.de ([195.135.220.15]:57165 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750846AbcIUMhp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Sep 2016 08:37:45 -0400
Date: Wed, 21 Sep 2016 14:37:37 +0200
Message-ID: <s5hk2e5l97y.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>,
        Jaroslav Kysela <perex@perex.cz>,
        Randy Dunlap <randy.dunlap@oracle.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: snd-usb-line6 depends on CONFIG_SND_HWDEP
In-Reply-To: <046fe4be-f3e8-0088-8b1d-ed94bb9ef914@sakamocchi.jp>
References: <86590.1474409693@turing-police.cc.vt.edu>
        <046fe4be-f3e8-0088-8b1d-ed94bb9ef914@sakamocchi.jp>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 21 Sep 2016 03:56:05 +0200,
Takashi Sakamoto wrote:
> 
> On Sep 21 2016 07:14, Valdis Kletnieks wrote:
> > ALSA - snd-usb-line6 depends on CONFIG_SND_HWDEP
> >
> > ERROR: "snd_hwdep_new" [sound/usb/line6/snd-usb-line6.ko] undefined!
> > scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> > make[1]: *** [__modpost] Error 1
> >
> > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> 
> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> 
> As a nitpicking, I think it better to change the subject line with a
> prefix of 'ALSA: line6:' or 'ALSA: usb-line6:', following to our
> fashion.

Yes, I modified the subject line and added fixes tag.


thanks,

Takashi


> > diff --git a/sound/usb/line6/Kconfig b/sound/usb/line6/Kconfig
> > index 8ffcf48097d9..39b400392d71 100644
> > --- a/sound/usb/line6/Kconfig
> > +++ b/sound/usb/line6/Kconfig
> > @@ -2,6 +2,7 @@ config SND_USB_LINE6
> >  	tristate
> >  	select SND_RAWMIDI
> >  	select SND_PCM
> > +	select SND_HWDEP
> >
> >  config SND_USB_POD
> >  	tristate "Line 6 POD USB support"
> 
> 
> Thanks
> 
> Takashi Sakamoto
>