From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753811AbbJSPev (ORCPT <rfc822;w@1wt.eu>);
	Mon, 19 Oct 2015 11:34:51 -0400
Received: from mx2.suse.de ([195.135.220.15]:35156 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751533AbbJSPeu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 19 Oct 2015 11:34:50 -0400
Date: Mon, 19 Oct 2015 17:34:48 +0200
Message-ID: <s5hk2qi3m93.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Mark Brown" <broonie@kernel.org>
Cc: "Dan Williams" <dan.j.williams@intel.com>,
        "Liam Girdwood" <lgirdwood@gmail.com>, "Jeeja KP" <jeeja.kp@intel.com>,
        <linux-arm-kernel@lists.infradead.org>,
        "Jaroslav Kysela" <perex@perex.cz>, <linux-arch@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 11/20] sound, skylake: switch from ioremap_cache to memremap
In-Reply-To: <20151019152641.GC32054@sirena.org.uk>
References: <20151009221537.32203.5867.stgit@dwillia2-desk3.jf.intel.com>
	<20151009221635.32203.30755.stgit@dwillia2-desk3.jf.intel.com>
	<20151019152641.GC32054@sirena.org.uk>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 19 Oct 2015 17:26:41 +0200,
Mark Brown wrote:
> 
> On Fri, Oct 09, 2015 at 06:16:36PM -0400, Dan Williams wrote:
> > In preparation for deprecating ioremap_cache() convert its usage in
> > skl-nhlt to memremap.
> 
> > -void __iomem *skl_nhlt_init(struct device *dev)
> > +void *skl_nhlt_init(struct device *dev)
> 
> Why are we loosing the annotation here?

It's the exact purpose of this patchset, as far as I understand.
memremap() allows the driver accessing the mapped memory just like a
normal memory unlike ioremap().


Takashi