From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934674AbbI2KdH (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Sep 2015 06:33:07 -0400
Received: from mx2.suse.de ([195.135.220.15]:41214 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S934404AbbI2KdE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Sep 2015 06:33:04 -0400
Date: Tue, 29 Sep 2015 12:33:00 +0200
Message-ID: <s5hk2r9zfab.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Pravin Shelar <pshelar@nicira.com>
Cc: "David S. Miller" <davem@davemloft.net>,
        Trond Myklebust <trond.myklebust@primarydata.com>,
        Anupam Chanda <achanda@vmware.com>, Tom Herbert <tom@herbertland.com>,
        netdev <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: 4.3-rc3 Regression: NFS access stall by commit 6ae459bdaaee
In-Reply-To: <CALnjE+rpcayxdyXwkDAqJeBgJUTOGACoGEKZRq=GhE+RDuF0OQ@mail.gmail.com>
References: <s5ha8s6bscn.wl-tiwai@suse.de>
	<CALnjE+rpcayxdyXwkDAqJeBgJUTOGACoGEKZRq=GhE+RDuF0OQ@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 29 Sep 2015 02:35:04 +0200,
Pravin Shelar wrote:
> 
> On Mon, Sep 28, 2015 at 6:12 AM, Takashi Iwai <tiwai@suse.de> wrote:
> > [I resent this since the previous mail didn't go out properly, as it
> >  seems; apologies if you already read it, please disregard]
> >
> > Hi,
> >
> > I noticed that NFS access from my workstation slowed down drastically,
> > almost stalls, with the fresh 4.3-rc3.  There are no particular kernel
> > errors / warnings.
> >
> > Then I performed git section, and it leaded to the commit:
> > 6ae459bdaaeebc632b16e54dcbabb490c6931d61
> >     skbuff: Fix skb checksum flag on skb pull
> >
> > Reverting this commit from 4.3-rc3 fixed the issue indeed.
> >
> > Could you take a look at this?  I added Trond to Cc in case he might
> > already know of it.
> >
> I send out fix for similar issue. Can you try the posted patch.
> https://patchwork.ozlabs.org/patch/523632/

Yes, the patch fixes the problem, thanks.  Feel free to take my
tested-by tag:
  Tested-by: Takashi Iwai <tiwai@suse.de>

But I guess the real fix is only the first chunk and the latter is
nothing but a cleanup?  If so, it'd be better to split it.


Takashi