mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Jaroslav Kysela <perex@perex.cz>,
	linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH 4/5] sound: dmasound_atari: Remove obsolete IRQ_TYPE_SLOW
Date: Mon, 12 Jan 2015 17:07:00 +0100	[thread overview]
Message-ID: <s5hk30sj84b.wl-tiwai@suse.de> (raw)
In-Reply-To: <1421052021-12560-5-git-send-email-geert@linux-m68k.org>

At Mon, 12 Jan 2015 09:40:20 +0100,
Geert Uytterhoeven wrote:
> 
> IRQ_TYPE_SLOW is no longer used by the Atari platform interrupt code
> since commit 734085651c9b80aa ("[PATCH] m68k: convert atari irq code")
> in v2.6.18-rc1, so drop it.
> 
> Note that its value has been reused for a different purpose
> (IRQ_TYPE_NONE) since commit 6a6de9ef5850d063 ("[PATCH] genirq: core")
> in v2.6.18-rc1.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: alsa-devel@alsa-project.org

I guess it's easier to take all patches into your tree, so take my
ack:
  Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi

> ---
>  sound/oss/dmasound/dmasound_atari.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/oss/dmasound/dmasound_atari.c b/sound/oss/dmasound/dmasound_atari.c
> index 13c214466d3b9f0e..1c56bf58eff906e0 100644
> --- a/sound/oss/dmasound/dmasound_atari.c
> +++ b/sound/oss/dmasound/dmasound_atari.c
> @@ -851,7 +851,7 @@ static int __init AtaIrqInit(void)
>  	st_mfp.tim_dt_a = 1;	/* Cause interrupt after first event. */
>  	st_mfp.tim_ct_a = 8;	/* Turn on event counting. */
>  	/* Register interrupt handler. */
> -	if (request_irq(IRQ_MFP_TIMA, AtaInterrupt, IRQ_TYPE_SLOW, "DMA sound",
> +	if (request_irq(IRQ_MFP_TIMA, AtaInterrupt, 0, "DMA sound",
>  			AtaInterrupt))
>  		return 0;
>  	st_mfp.int_en_a |= 0x20;	/* Turn interrupt on. */
> -- 
> 1.9.1
> 

  reply	other threads:[~2015-01-12 16:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12  8:40 [PATCH 0/5] m68k/atari: Remove obsolete IRQ_TYPE_* Geert Uytterhoeven
2015-01-12  8:40 ` [PATCH 1/5] net: atarilance: Remove obsolete IRQ_TYPE_PRIO Geert Uytterhoeven
2015-01-12 17:56   ` David Miller
2015-01-12  8:40 ` [PATCH 2/5] parport: parport_atari: Remove obsolete IRQ_TYPE_SLOW Geert Uytterhoeven
2015-01-12  8:40 ` [PATCH 3/5] video: atafb: Remove obsolete IRQ_TYPE_PRIO Geert Uytterhoeven
2015-01-13 12:51   ` Tomi Valkeinen
2015-01-12  8:40 ` [PATCH 4/5] sound: dmasound_atari: Remove obsolete IRQ_TYPE_SLOW Geert Uytterhoeven
2015-01-12 16:07   ` Takashi Iwai [this message]
2015-01-12  8:40 ` [PATCH 5/5] m68k/atari: Remove obsolete IRQ_TYPE_* Geert Uytterhoeven
2015-01-15 13:07 ` [PATCH 0/5] " Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hk30sj84b.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome