From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753218AbaIJOnG (ORCPT ); Wed, 10 Sep 2014 10:43:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43550 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752270AbaIJOnE (ORCPT ); Wed, 10 Sep 2014 10:43:04 -0400 Date: Wed, 10 Sep 2014 16:43:03 +0200 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: Johannes Berg , Jaroslav Kysela , linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: aoa: printk replacement In-Reply-To: <20140910143204.GA30695@sudip-PC> References: <1410357107-29933-1-git-send-email-sudipm.mukherjee@gmail.com> <1410357424.2761.5.camel@jlt4.sipsolutions.net> <20140910143204.GA30695@sudip-PC> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 10 Sep 2014 20:02:04 +0530, Sudip Mukherjee wrote: > > On Wed, Sep 10, 2014 at 03:57:04PM +0200, Johannes Berg wrote: > > On Wed, 2014-09-10 at 19:21 +0530, Sudip Mukherjee wrote: > > > as pr_* macros are more preffered over printk, so printk replaced > > > with corresponding pr_* macros. > > > > Are you simply running checkpatch on every file and decided to do > > something about it? :) > > > i am running checkpatch on the patch generated. if i am doing checkpatch > cleanups then that i do it only in the staging. > only exception : printk .. :) > > > I'll let Takashi decide whether to take this or not as I no longer care > > about this code, but IMHO this changes is completely pointless since you > > don't also clean up the code to have a common prefix with #define pr_fmt > > and then clean up the callers etc. > > > i mentioned in the comment that in a future patch we can have pr_fmt, > it was not done in this patch since the changes for this patch is > generated by a script and not manually. > if Takashi accepts this then the next patch will have pr_fmt. If you're going to work on it, please give a patch series and let me merge once. There is no good merit to merge a half-baked piece by piece. Regarding the changes you've made: so far, I've merged two such patches just because it's a good exercise for newbies. You've played it and experienced it enough. So it's time to go up to a higher stage, more "real" fixes. For example, if you are still interested in printk stuff, try to change the calls to dev_err() and co. Of course, this needs more understanding of the code you'll handle, which object is passed for which messages. thanks, Takashi