From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754838AbaE1PvZ (ORCPT ); Wed, 28 May 2014 11:51:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60404 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753841AbaE1PvX (ORCPT ); Wed, 28 May 2014 11:51:23 -0400 Date: Wed, 28 May 2014 17:51:21 +0200 Message-ID: From: Takashi Iwai To: Benoit Taine Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/2] ALSA: au1x00: Use resource_size instead of computation In-Reply-To: <1401290047-30005-2-git-send-email-benoit.taine@lip6.fr> References: <1401290047-30005-1-git-send-email-benoit.taine@lip6.fr> <1401290047-30005-2-git-send-email-benoit.taine@lip6.fr> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 28 May 2014 17:14:06 +0200, Benoit Taine wrote: > > This issue was reported by coccicheck using the semantic patch > at scripts/coccinelle/api/resource_size.cocci > > Signed-off-by: Benoit Taine Applied, thanks. Takashi > --- > Not compile tested, due incompatible architecture. > > sound/mips/au1x00.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/mips/au1x00.c b/sound/mips/au1x00.c > index d10ef76..fbcaa54 100644 > --- a/sound/mips/au1x00.c > +++ b/sound/mips/au1x00.c > @@ -648,14 +648,14 @@ static int au1000_ac97_probe(struct platform_device *pdev) > goto out; > > err = -EBUSY; > - au1000->ac97_res_port = request_mem_region(r->start, > - r->end - r->start + 1, pdev->name); > + au1000->ac97_res_port = request_mem_region(r->start, resource_size(r), > + pdev->name); > if (!au1000->ac97_res_port) { > snd_printk(KERN_ERR "ALSA AC97: can't grab AC97 port\n"); > goto out; > } > > - io = ioremap(r->start, r->end - r->start + 1); > + io = ioremap(r->start, resource_size(r)); > if (!io) > goto out; > >