From: Takashi Iwai <tiwai@suse.de>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 8/8] sound: Remove OOM message after input_allocate_device
Date: Thu, 24 Oct 2013 11:26:21 +0200 [thread overview]
Message-ID: <s5hk3h3nhoi.wl%tiwai@suse.de> (raw)
In-Reply-To: <67fa483a408bf2abe0e2fad829f3c496130ae507.1382555436.git.joe@perches.com>
At Wed, 23 Oct 2013 12:14:54 -0700,
Joe Perches wrote:
>
> Emitting an OOM message isn't necessary after input_allocate_device
> as there's a generic OOM and a dump_stack already done.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Thanks, applied.
Takashi
> ---
> sound/pci/hda/hda_beep.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/pci/hda/hda_beep.c b/sound/pci/hda/hda_beep.c
> index 63c9909..20d065a 100644
> --- a/sound/pci/hda/hda_beep.c
> +++ b/sound/pci/hda/hda_beep.c
> @@ -151,10 +151,8 @@ static int snd_hda_do_attach(struct hda_beep *beep)
> int err;
>
> input_dev = input_allocate_device();
> - if (!input_dev) {
> - printk(KERN_INFO "hda_beep: unable to allocate input device\n");
> + if (!input_dev)
> return -ENOMEM;
> - }
>
> /* setup digital beep device */
> input_dev->name = "HDA Digital PCBeep";
> --
> 1.8.1.2.459.gbcd45b4.dirty
>
prev parent reply other threads:[~2013-10-24 9:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 19:14 [PATCH 0/8] treewide: Remove OOM message after input_alloc_device Joe Perches
2013-10-23 19:14 ` [PATCH 1/8] Documentation: Remove OOM message after input_allocate_device Joe Perches
2013-10-23 19:14 ` [PATCH 2/8] cell: " Joe Perches
2013-10-23 20:49 ` [Cbe-oss-dev] " Geoff Levand
2013-10-23 19:14 ` [PATCH 3/8] hid: " Joe Perches
2013-10-23 19:14 ` [PATCH 4/8] input: " Joe Perches
2013-10-24 18:26 ` Uwe Kleine-König
2013-10-24 18:43 ` Joe Perches
2013-10-24 18:46 ` Uwe Kleine-König
2013-10-24 18:48 ` Joe Perches
2013-10-24 19:15 ` Uwe Kleine-König
2013-10-24 18:37 ` Dmitry Torokhov
2013-10-24 18:45 ` Joe Perches
2013-10-24 19:10 ` Dmitry Torokhov
2013-10-24 19:20 ` Joe Perches
2013-10-23 19:14 ` [PATCH 5/8] media: " Joe Perches
2013-10-23 19:14 ` [PATCH 6/8] platform:x86: " Joe Perches
2013-10-24 9:31 ` Henrique de Moraes Holschuh
2013-11-20 23:55 ` Matthew Garrett
2013-10-23 19:14 ` [PATCH 7/8] staging: " Joe Perches
2013-10-24 8:30 ` Jonathan Cameron
2013-10-23 19:14 ` [PATCH 8/8] sound: " Joe Perches
2013-10-24 9:26 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk3h3nhoi.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®