From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757635Ab1KPRPd (ORCPT ); Wed, 16 Nov 2011 12:15:33 -0500 Received: from cantor2.suse.de ([195.135.220.15]:41003 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756243Ab1KPRP3 (ORCPT ); Wed, 16 Nov 2011 12:15:29 -0500 Date: Wed, 16 Nov 2011 18:15:28 +0100 Message-ID: From: Takashi Iwai To: Daniel Mack Cc: Chris Wilson , dri-devel@lists.freedesktop.org, jbarnes@virtuousgeek.org, harald@redhat.com, Keith Packard , linux-kernel@vger.kernel.org Subject: Re: Strange effect with i915 backlight controller In-Reply-To: <4EC3B391.90001@gmail.com> References: <4EB3F860.6010408@gmail.com> <4EB87E6A.3060403@gmail.com> <4EBBE9A1.8020501@gmail.com> <4EBFEF29.9050005@gmail.com> <4EC3B391.90001@gmail.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 16 Nov 2011 13:58:57 +0100, Daniel Mack wrote: > > On 11/14/2011 11:39 AM, Takashi Iwai wrote: > > OK, then perhaps a better fix is to change the check to be equivalent > > with pineview, as you mentioned in the original post. The handling of > > bit 0 for old chips was lost during the refactoring of backlight code > > since 2.6.37. > > > > Does the patch below work for you? > > > > The only concern by this fix is that it changes the max value. If > > apps expect some certain (e.g. recorded) value, it may screw up. But > > I don't expect this would happen with sane apps. > > Works perfectly - let's ship it :) OK, now the patch was resent to intel-gfx with proper tags. thanks, Takashi