From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752855Ab0CBMGW (ORCPT ); Tue, 2 Mar 2010 07:06:22 -0500 Received: from cantor2.suse.de ([195.135.220.15]:33825 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752181Ab0CBMGU (ORCPT ); Tue, 2 Mar 2010 07:06:20 -0500 Date: Tue, 02 Mar 2010 13:06:19 +0100 Message-ID: From: Takashi Iwai To: Arseniy Lartsev Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] usbaudio: Fix wrong bitrate for Creative Creative VF0470 Live Cam In-Reply-To: <201003021452.28716.arseniy@fizlesh.ru> References: <201003021452.28716.arseniy@fizlesh.ru> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 2 Mar 2010 14:52:28 +0300, Arseniy Lartsev wrote: > > This patch works around misbehaviour of Creative Creative VF0470 Live Cam > which reports 16 kHz sample rate for audio capture while actually producing > 8 kHz stream. > > Signed-off-by: Arseniy Lartsev Thanks. Applied now with minor coding-style fixes. Takashi > -- > diff -rup linux-2.6.33-rc8-orig/sound/usb/usbaudio.c linux-2.6.33- > rc8/sound/usb/usbaudio.c > --- linux-2.6.33-rc8-orig/sound/usb/usbaudio.c > +++ linux-2.6.33-rc8/sound/usb/usbaudio.c > @@ -2513,6 +2513,9 @@ static int parse_audio_format_rates(stru > chip->usb_id == USB_ID(0x0d8c, 0x0102)) && > fp->altsetting == 5 && fp->maxpacksize == 392) > rate = 96000; > + /* Creative VF0470 Live Cam reports 16 kHz instead of 8 */ > + if ((rate == 16000) && (chip->usb_id == USB_ID(0x041e, 0x4068))) > + rate = 8000; > fp->rate_table[fp->nr_rates] = rate; > if (!fp->rate_min || rate < fp->rate_min) > fp->rate_min = rate; >