From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1753524AbZGTNO2@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753524AbZGTNO2 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Jul 2009 09:14:28 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752956AbZGTNO0
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 20 Jul 2009 09:14:26 -0400
Received: from cantor.suse.de ([195.135.220.2]:37889 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751807AbZGTNO0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Jul 2009 09:14:26 -0400
Date: Mon, 20 Jul 2009 15:14:25 +0200
Message-ID: <s5hk5235wem.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Robin Holt <holt@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Commit 1e137f92 broke my Vaio VGN-FE550G's hda_intel driver.
In-Reply-To: <20090720122623.GL6876@sgi.com>
References: <20090719140102.GI6876@sgi.com>
	<s5hy6qkk6am.wl%tiwai@suse.de>
	<20090719225538.GK6876@sgi.com>
	<s5heisbc2rk.wl%tiwai@suse.de>
	<20090720122623.GL6876@sgi.com>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Mon, 20 Jul 2009 07:26:23 -0500,
Robin Holt wrote:
> 
> On Mon, Jul 20, 2009 at 08:00:31AM +0200, Takashi Iwai wrote:
> > At Sun, 19 Jul 2009 17:55:38 -0500,
> > Robin Holt wrote:
> > > 
> > > > What about to pass model=vaio?  Doesn't it work?
> > > 
> > > That didn't change the behavior.
> > > 
> > > > In anyways, please run alsa-info.sh with --no-upload option, and attach
> > > > the generated file.
> > > 
> > > Here is the output from alsa-info.sh.  This was from the module load without
> > > the model=vaio.  Below, (search for ---Robin---) is the output from alsa-info.sh
> > > with model=vaio.
> > 
> > Thanks.  This look really like a bug.  The pin definition was wrongly
> > placed.  It should have been before the pin overrides.
> > 
> > Could you try the patch below?  With the patch, the driver would work
> > even without any model option.
> 
> Patch worked perfectly.
> 
> Acked-by: Robin Holt <holt@sgi.com>

Thanks, the patch is now in sound GIT tree.


Takashi