From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756906AbZCTOWs (ORCPT ); Fri, 20 Mar 2009 10:22:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752481AbZCTOWj (ORCPT ); Fri, 20 Mar 2009 10:22:39 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55544 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752154AbZCTOWi (ORCPT ); Fri, 20 Mar 2009 10:22:38 -0400 Date: Fri, 20 Mar 2009 15:22:35 +0100 Message-ID: From: Takashi Iwai To: "Pascal de Bruijn | Unilogic Networks B.V." Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH] alsa: Intel HDA output and align Ids. In-Reply-To: <1237554056.6305.9.camel@carnifex> References: <1237554056.6305.9.camel@carnifex> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 20 Mar 2009 14:00:56 +0100, Pascal de Bruijn | Unilogic Networks B.V. wrote: > > Output Intel HDA Function Id in /proc/asound/cardX/codec#X > Align Vendor/Subsystem/Revision Ids to 8 characters, front-padded with zeros > > As submitted to Kernel Bugzilla #12888 > > Signed-off-by: Pascal de Bruijn Thanks for the patch. The changes look OK, but could you make a patch against the latest 2.6.29-rc tree, and fix a coding issue reported by checkpatch.pl? Also, a bit more explanatory subject would be helpful... Takashi > > diff -Nurp linux-2.6.28.8-orig/sound/pci/hda/hda_codec.c linux-2.6.28.8-func/sound/pci/hda/hda_codec.c > --- linux-2.6.28.8-orig/sound/pci/hda/hda_codec.c 2009-03-17 01:50:03.000000000 +0100 > +++ linux-2.6.28.8-func/sound/pci/hda/hda_codec.c 2009-03-17 10:39:45.000000000 +0100 > @@ -519,9 +519,8 @@ static void __devinit setup_fg_nodes(str > > total_nodes = snd_hda_get_sub_nodes(codec, AC_NODE_ROOT, &nid); > for (i = 0; i < total_nodes; i++, nid++) { > - unsigned int func; > - func = snd_hda_param_read(codec, nid, AC_PAR_FUNCTION_TYPE); > - switch (func & 0xff) { > + codec->function_id = snd_hda_param_read(codec, nid, AC_PAR_FUNCTION_TYPE) & 0xff; > + switch (codec->function_id) { > case AC_GRP_AUDIO_FUNCTION: > codec->afg = nid; > break; > diff -Nurp linux-2.6.28.8-orig/sound/pci/hda/hda_codec.h linux-2.6.28.8-func/sound/pci/hda/hda_codec.h > --- linux-2.6.28.8-orig/sound/pci/hda/hda_codec.h 2009-03-17 01:50:03.000000000 +0100 > +++ linux-2.6.28.8-func/sound/pci/hda/hda_codec.h 2009-03-17 10:39:45.000000000 +0100 > @@ -693,6 +693,7 @@ struct hda_codec { > hda_nid_t mfg; /* MFG node id */ > > /* ids */ > + u32 function_id; > u32 vendor_id; > u32 subsystem_id; > u32 revision_id; > diff -Nurp linux-2.6.28.8-orig/sound/pci/hda/hda_proc.c linux-2.6.28.8-func/sound/pci/hda/hda_proc.c > --- linux-2.6.28.8-orig/sound/pci/hda/hda_proc.c 2009-03-17 01:50:03.000000000 +0100 > +++ linux-2.6.28.8-func/sound/pci/hda/hda_proc.c 2009-03-17 10:40:08.000000000 +0100 > @@ -520,9 +520,10 @@ static void print_codec_info(struct snd_ > snd_hda_get_codec_name(codec, buf, sizeof(buf)); > snd_iprintf(buffer, "Codec: %s\n", buf); > snd_iprintf(buffer, "Address: %d\n", codec->addr); > - snd_iprintf(buffer, "Vendor Id: 0x%x\n", codec->vendor_id); > - snd_iprintf(buffer, "Subsystem Id: 0x%x\n", codec->subsystem_id); > - snd_iprintf(buffer, "Revision Id: 0x%x\n", codec->revision_id); > + snd_iprintf(buffer, "Function Id: 0x%x\n", codec->function_id); > + snd_iprintf(buffer, "Vendor Id: 0x%08x\n", codec->vendor_id); > + snd_iprintf(buffer, "Subsystem Id: 0x%08x\n", codec->subsystem_id); > + snd_iprintf(buffer, "Revision Id: 0x%08x\n", codec->revision_id); > > if (codec->mfg) > snd_iprintf(buffer, "Modem Function Group: 0x%x\n", codec->mfg); > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >