From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1755109AbZBDLnU@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755109AbZBDLnU (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Feb 2009 06:43:20 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751869AbZBDLnL
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 4 Feb 2009 06:43:11 -0500
Received: from ns2.suse.de ([195.135.220.15]:56356 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750837AbZBDLnJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Feb 2009 06:43:09 -0500
Date: Wed, 04 Feb 2009 12:43:03 +0100
Message-ID: <s5hk586a0mw.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Sam Ravnborg <sam@ravnborg.org>,
       alsa-devel@alsa-project.org, Ingo Molnar <mingo@elte.hu>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: usr/include/linux/soundcard.h warnings for 'make headers_check'
In-Reply-To: <1233747097.5563.29.camel@localhost.localdomain>
References: <1232465902.3088.31.camel@localhost.localdomain>
	<s5h7i4psepm.wl%tiwai@suse.de>
	<20090121054138.GA26551@uranus.ravnborg.org>
	<200902032127.24526.arnd@arndb.de>
	<1233720252.3595.5.camel@localhost.localdomain>
	<s5hhc3ak8ns.wl%tiwai@suse.de>
	<1233736494.3198.15.camel@localhost.localdomain>
	<s5h4ozak20l.wl%tiwai@suse.de>
	<1233743877.5563.7.camel@localhost.localdomain>
	<s5hy6wma2zw.wl%tiwai@suse.de>
	<1233747097.5563.29.camel@localhost.localdomain>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Wed, 04 Feb 2009 17:01:37 +0530,
Jaswinder Singh Rajput wrote:
> 
> On Wed, 2009-02-04 at 11:52 +0100, Takashi Iwai wrote:
> > At Wed, 04 Feb 2009 16:07:57 +0530,
> > Jaswinder Singh Rajput wrote:
> > > 
> > > In kernel space we use USE_SEQ_MACROS in:
> > > sound/oss/mpu401.c
> > > sound/oss/midi_synth.c
> > > 
> > > so we can replace
> > > #if (!defined(__KERNEL__) && !defined(KERNEL) && !defined(INKERNEL) && !defined(_KERNEL)) || defined(USE_SEQ_MACROS)
> > > with
> > > #ifdef USE_SEQ_MACROS
> > 
> > Then this will break user-space apps.  They don't define
> > USE_SEQ_MACROS always.
> > 
> 
> If userspace apps are coming through sys/soundcard.h

It's not always true -- that's the whole problem I'm concerned.
Apparently old apps do include linux/soundcard.h.

I agree to remove the stuff causing warnings, i.e. moving oss-lib part
to sys/soundcard.h.  In this case, the only possible regression is the
case where apps use OSS-lib and include linux/soundcard.h.  For other
cases (use sequencer stuff with linux/soundcard.h but without
oss-lib), it will still work.


Takashi