From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755262AbYK0NnU (ORCPT ); Thu, 27 Nov 2008 08:43:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752177AbYK0NnJ (ORCPT ); Thu, 27 Nov 2008 08:43:09 -0500 Received: from mx1.suse.de ([195.135.220.2]:36359 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbYK0NnI (ORCPT ); Thu, 27 Nov 2008 08:43:08 -0500 Date: Thu, 27 Nov 2008 14:43:06 +0100 Message-ID: From: Takashi Iwai To: Julia Lawall Cc: perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] sound/pci/mixart/mixart.c: Add missing snd_card_free In-Reply-To: References: User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 27 Nov 2008 14:33:30 +0100 (CET), Julia Lawall wrote: > > Oops, please ignore this patch. There is a problem, but the modification > is not correct. How about the patch below? Takashi --- diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c index ae7601f..3cccfed 100644 --- a/sound/pci/mixart/mixart.c +++ b/sound/pci/mixart/mixart.c @@ -989,6 +989,7 @@ static int snd_mixart_pcm_digital(struct snd_mixart *chip) static int snd_mixart_chip_free(struct snd_mixart *chip) { + chip->mgr->chip[chip->chip_idx] = NULL; kfree(chip); return 0; }