From: Takashi Iwai <tiwai@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
svens@stackframe.org, joerg.roedel@amd.com,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: swiotlb_alloc_coherent: allocated memory is out of range for device
Date: Tue, 28 Oct 2008 11:36:13 +0100 [thread overview]
Message-ID: <s5hk5btm2g2.wl%tiwai@suse.de> (raw)
In-Reply-To: <20081023101557.GA30302@elte.hu>
At Thu, 23 Oct 2008 12:15:57 +0200,
Ingo Molnar wrote:
>
>
> * Takashi Iwai <tiwai@suse.de> wrote:
>
> > At Thu, 23 Oct 2008 07:22:09 +0200,
> > I wrote:
> > >
> > > > The current dma_alloc_coherent (asm-x86/dma-mapping.h) handles the gfp
> > > > flags in the exact same way as the old dma_alloc_coherent
> > > > (pci-dma.c). Neither sets GFP_DMA even if coherent_dma_mask is
> > > > 24bits. The old code is fine because of the GFP_DMA retry
> > > > mechanism. But if coherent_dma_mask is 24bits, there is no point to go
> > > > into the GFP_DMA retry mechanism. We should use GFP_DMA in the first
> > > > place.
> > > >
> > > > How about the following patch?
> > >
> > > I'll give it a try later (the machine is in my office).
> >
> > The patch seems working fine. Thanks!
> >
> > Tested-by: Takashi Iwai <tiwai@suse.de>
>
> thanks guys - i've queued it up in tip/core/urgent and will send a pull
> request to Linus later today.
Ingo, what is the status about these patches?
They don't appear in rc2.
thanks,
Takashi
next prev parent reply other threads:[~2008-10-28 10:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-19 10:09 Sven Schnelle
2008-10-22 10:53 ` Takashi Iwai
2008-10-22 11:07 ` Takashi Iwai
2008-10-22 11:29 ` FUJITA Tomonori
2008-10-22 12:06 ` Takashi Iwai
2008-10-22 13:13 ` FUJITA Tomonori
2008-10-22 13:19 ` FUJITA Tomonori
2008-10-22 13:32 ` Takashi Iwai
2008-10-23 2:36 ` FUJITA Tomonori
2008-10-23 5:22 ` Takashi Iwai
2008-10-23 11:58 ` Takashi Iwai
2008-10-23 10:15 ` Ingo Molnar
2008-10-23 11:46 ` FUJITA Tomonori
2008-10-28 10:36 ` Takashi Iwai [this message]
2008-10-28 10:39 ` Ingo Molnar
2008-10-28 10:47 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk5btm2g2.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hpa@zytor.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome