From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761587AbYD3KmE (ORCPT ); Wed, 30 Apr 2008 06:42:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756474AbYD3Kly (ORCPT ); Wed, 30 Apr 2008 06:41:54 -0400 Received: from ns.suse.de ([195.135.220.2]:39446 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756370AbYD3Klx (ORCPT ); Wed, 30 Apr 2008 06:41:53 -0400 Date: Wed, 30 Apr 2008 12:41:52 +0200 Message-ID: From: Takashi Iwai To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab Subject: Re: [patch] sound/video: fix sound/i2c/other/tea575x-tuner.c build bug In-Reply-To: <20080429204643.GA22078@elte.hu> References: <20080429204643.GA22078@elte.hu> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 29 Apr 2008 22:46:43 +0200, Ingo Molnar wrote: > > > fix build failure triggered on latest -git by this config: > > http://redhat.com/~mingo/misc/config-Tue_Apr_29_22_33_36_CEST_2008.bad > > sound/i2c/other/tea575x-tuner.c: In function 'snd_tea575x_ioctl': > sound/i2c/other/tea575x-tuner.c:95: error: 'VIDIOCGCAP' undeclared (first use in this function) > sound/i2c/other/tea575x-tuner.c:95: error: (Each undeclared identifier is reported only once > sound/i2c/other/tea575x-tuner.c:95: error: for each function it appears in.) > sound/i2c/other/tea575x-tuner.c:97: error: storage size of 'v' isn't known > > the CONFIG_SND_FM801_TEA575X code still depends on VIDEO_V4L1_COMPAT > APIs. I'm afraid that the select of VIDEO_V4L1 from fm801 makes the things messy enough. And more select, eh... IMO, this should be rather depend on VIDEO_V4L1. But, there is a dependency chain problem among snd-fm801, snd-fm801-tea575x and V4L layer. I'll check it. Takashi > > Signed-off-by: Ingo Molnar > --- > sound/pci/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > Index: linux/sound/pci/Kconfig > =================================================================== > --- linux.orig/sound/pci/Kconfig > +++ linux/sound/pci/Kconfig > @@ -529,6 +529,7 @@ config SND_FM801_TEA575X > depends on SND_FM801_TEA575X_BOOL > default SND_FM801 > select VIDEO_V4L1 > + select VIDEO_V4L1_COMPAT > select VIDEO_DEV > > config SND_HDA_INTEL >