From: Takashi Iwai <tiwai@suse.de>
To: Meelis Roos <mroos@linux.ee>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Sound core broken on sparc64 (2.6.4+bk)
Date: Tue, 16 Mar 2004 14:42:26 +0100 [thread overview]
Message-ID: <s5hk71kgb7h.wl@alsa2.suse.de> (raw)
In-Reply-To: <Pine.GSO.4.44.0403161513470.29946-100000@math.ut.ee>
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
At Tue, 16 Mar 2004 15:28:00 +0200 (EET),
Meelis Roos wrote:
>
> > the attached patch should fix.
>
> Yes, thanks! This is also fixed in mainline by now.
>
> Ths leads me to the next error:
>
> sound/sparc/cs4231.c: In function `snd_cs4231_pcm':
> sound/sparc/cs4231.c:1573: error: `SNDRV_DMA_TYPE_PCI' undeclared (first use in this function)
> sound/sparc/cs4231.c:1573: error: (Each undeclared identifier is reported only once
> sound/sparc/cs4231.c:1573: error: for each function it appears in.)
> sound/sparc/cs4231.c:1575: error: parse error before numeric constant
>
> SNDRV_DMA_TYPE_PCI used to be defined in <sound/memalloc.h> but is now
> gone.
grrr, it's a typo of SNDRV_DMA_TYPE_DEV.
thanks for the report.
Takashi
[-- Attachment #2: Type: text/plain, Size: 429 bytes --]
--- linux/sound/sparc/cs4231.c 6 Mar 2004 17:30:24 -0000 1.10
+++ linux/sound/sparc/cs4231.c 16 Mar 2004 13:40:15 -0000
@@ -1570,7 +1570,7 @@
#ifdef EBUS_SUPPORT
if (chip->flags & CS4231_FLAG_EBUS) {
- snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_PCI,
+ snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
snd_dma_pci_data(chip->dev_u.pdev)
64*1024, 128*1024);
} else {
next prev parent reply other threads:[~2004-03-16 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-15 13:46 Meelis Roos
2004-03-15 18:10 ` Takashi Iwai
2004-03-16 13:28 ` Meelis Roos
2004-03-16 13:42 ` Takashi Iwai [this message]
2004-03-16 14:00 ` Meelis Roos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk71kgb7h.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®