From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1131CC433F5
	for <linux-kernel@archiver.kernel.org>; Mon, 13 Dec 2021 09:38:00 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232969AbhLMJh6 (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 13 Dec 2021 04:37:58 -0500
Received: from smtp-out1.suse.de ([195.135.220.28]:37690 "EHLO
        smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234376AbhLMJgf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Dec 2021 04:36:35 -0500
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out1.suse.de (Postfix) with ESMTP id 63981210E6;
        Mon, 13 Dec 2021 09:36:34 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1639388194; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=pEji7qG1lTG6T1BGFdtW1A7Ap+VS97P266CofDR8fQ8=;
        b=A+zJ5xJxX03S4bo/5eo+q0q17dJxAR8omRSL73uYL66E7GtZr5QegeqmsRIlIwzBO5Vlhe
        YY5R4D3bdEdzPux+yX8TCxV8VyHCXjmL/89+n3QFI1eJumR9fro+yo/h9A+xDfV8SXrGNH
        VDtmd41Z+YwYIFjWKf/Fb0Cymt8VOBo=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1639388194;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=pEji7qG1lTG6T1BGFdtW1A7Ap+VS97P266CofDR8fQ8=;
        b=auCY3scAiBCqb0omX8COw2CSytol3N654vmh13IKj5jR9/uAVphBDD/iZC2FOtNafX3qxr
        WjWKZ/3LmTgUfRDg==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id 43A62A3B8B;
        Mon, 13 Dec 2021 09:36:34 +0000 (UTC)
Date:   Mon, 13 Dec 2021 10:36:34 +0100
Message-ID: <s5hlf0oeti5.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: drivers: opl3: Fix incorrect use of vp->state
In-Reply-To: <20211212172025.470367-1-colin.i.king@gmail.com>
References: <20211212172025.470367-1-colin.i.king@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 12 Dec 2021 18:20:25 +0100,
Colin Ian King wrote:
> 
> Static analysis with scan-build has found an assignment to vp2 that is
> never used. It seems that the check on vp->state > 0 should be actually
> on vp2->state instead. Fix this.
> 
> This dates back to 2002, I found the offending commit from the git
> history git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git,
> commit 91e39521bbf6 ("[PATCH] ALSA patch for 2.5.4")
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Thanks, applied now with Cc-to-stable.


Takashi