From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCAB8C433B4 for ; Fri, 16 Apr 2021 10:42:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99D0261103 for ; Fri, 16 Apr 2021 10:42:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241734AbhDPKmX (ORCPT ); Fri, 16 Apr 2021 06:42:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:39476 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229502AbhDPKmW (ORCPT ); Fri, 16 Apr 2021 06:42:22 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 59572AFEC; Fri, 16 Apr 2021 10:41:57 +0000 (UTC) Date: Fri, 16 Apr 2021 12:41:57 +0200 Message-ID: From: Takashi Iwai To: Yang Li Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: seq: oss: Fix inconsistent indenting In-Reply-To: <1618567244-5704-1-git-send-email-yang.lee@linux.alibaba.com> References: <1618567244-5704-1-git-send-email-yang.lee@linux.alibaba.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Apr 2021 12:00:44 +0200, Yang Li wrote: > > Kernel test robot throws below warning -> > > smatch warnings: > sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn: > inconsistent indenting > > Fixed the inconsistent indenting. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > sound/core/seq/oss/seq_oss_event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/core/seq/oss/seq_oss_event.c b/sound/core/seq/oss/seq_oss_event.c > index 7b7c925..9a42713 100644 > --- a/sound/core/seq/oss/seq_oss_event.c > +++ b/sound/core/seq/oss/seq_oss_event.c > @@ -294,7 +294,7 @@ > /* set volume to zero -- note off */ > // type = SNDRV_SEQ_EVENT_NOTEOFF; > //else > - if (info->ch[ch].vel) > + if (info->ch[ch].vel) > /* sample already started -- volume change */ > type = SNDRV_SEQ_EVENT_KEYPRESS; The line was aligned with the commented if block. If any, we should rather clean up and re-format the whole block. (But, OTOH, you shouldn't remove the stuff without understanding the context.) thanks, Takashi