From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F500C35242 for ; Tue, 11 Feb 2020 19:15:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D1D62173E for ; Tue, 11 Feb 2020 19:15:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731583AbgBKTPO (ORCPT ); Tue, 11 Feb 2020 14:15:14 -0500 Received: from mx2.suse.de ([195.135.220.15]:57952 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729934AbgBKTPO (ORCPT ); Tue, 11 Feb 2020 14:15:14 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8959DAE2C; Tue, 11 Feb 2020 19:15:12 +0000 (UTC) Date: Tue, 11 Feb 2020 20:15:12 +0100 Message-ID: From: Takashi Iwai To: Arvind Sankar Cc: Jaroslav Kysela , Takashi Iwai , , , Subject: Re: [PATCH] ALSA: usb-audio: Apply sample rate quirk for Audioengine D1 In-Reply-To: <20200211162235.1639889-1-nivedita@alum.mit.edu> References: <20200211162235.1639889-1-nivedita@alum.mit.edu> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Feb 2020 17:22:35 +0100, Arvind Sankar wrote: > > The Audioengine D1 (0x2912:0x30c8) does support reading the sample rate, > but it returns the rate in byte-reversed order. > > When setting sampling rate, the driver produces these warning messages: > [168840.944226] usb 3-2.2: current rate 4500480 is different from the runtime rate 44100 > [168854.930414] usb 3-2.2: current rate 8436480 is different from the runtime rate 48000 > [168905.185825] usb 3-2.1.2: current rate 30465 is different from the runtime rate 96000 > > As can be seen from the hexadecimal conversion, the current rate read > back is byte-reversed from the rate that was set. > > 44100 == 0x00ac44, 4500480 == 0x44ac00 > 48000 == 0x00bb80, 8436480 == 0x80bb00 > 96000 == 0x017700, 30465 == 0x007701 > > Rather than implementing a new quirk to reverse the order, just skip > checking the rate to avoid spamming the log. > > Signed-off-by: Arvind Sankar Thanks, applied now with Cc to stable. Takashi