From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B8B8C43331 for ; Tue, 12 Nov 2019 20:28:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4789C2196E for ; Tue, 12 Nov 2019 20:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727124AbfKLU2I (ORCPT ); Tue, 12 Nov 2019 15:28:08 -0500 Received: from mx2.suse.de ([195.135.220.15]:38868 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726388AbfKLU2I (ORCPT ); Tue, 12 Nov 2019 15:28:08 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4CDE7ACEC; Tue, 12 Nov 2019 20:28:06 +0000 (UTC) Date: Tue, 12 Nov 2019 21:28:06 +0100 Message-ID: From: Takashi Iwai To: Arnd Bergmann Cc: ALSA Development Mailing List , Takashi Iwai , Baolin Wang , y2038 Mailman List , "linux-kernel@vger.kernel.org" , Jaroslav Kysela , Mark Brown , Baolin Wang Subject: Re: [PATCH v6 2/8] ALSA: Avoid using timespec for struct snd_timer_status In-Reply-To: References: <20191112151642.680072-1-arnd@arndb.de> <20191112151642.680072-3-arnd@arndb.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Nov 2019 21:08:17 +0100, Arnd Bergmann wrote: > > On Tue, Nov 12, 2019 at 4:42 PM Takashi Iwai wrote: > > > > @@ -761,6 +761,7 @@ struct snd_timer_params { > > > unsigned char reserved[60]; /* reserved */ > > > }; > > > > > > +#ifndef __KERNEL__ > > > struct snd_timer_status { > > > struct timespec tstamp; /* Timestamp - last update */ > > > unsigned int resolution; /* current period resolution in ns */ > > > > Do we need this ifndef? Is it for stopping the reference of struct > > snd_timer_status from the kernel code but only 32 and 64 variants? > > Well spotted, this is indeed a very recent change I did to the patch. > The idea here is to hide any use of 'time_t', 'timespec' and 'timeval' > from kernel compilation. These types are now defined in an incompatible > way by libc, so we have to remove them from the kernel's uapi headers. > I would prefer to remove them completely from the kernel (rather than > moving them from uapi to internal headers) to make it harder to write > y2038-incompatible code, and with the 90 patches I sent this week, > all users are gone from the kernel (this series was the last part). Could you put this trick in the changelog, too? > Interestingly, hiding snd_timer_status from the drivers /also/ caught > a but in a file when I had missed a reference that needed to be converted > to snd_timer_status64. Heh, that's no surprising, proving the usefulness :) thanks, Takashi